r97650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97649‎ | r97650 | r97651 >
Date:19:13, 20 September 2011
Author:neilk
Status:ok
Tags:
Comment:
swap reported width and height for jpegmeta, if rotated 90 or 270 degrees
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -358,11 +358,20 @@
359359 this.imageinfo.metadata.orientation = meta.tiff.Orientation.value;
360360 }
361361 if ( meta.general ) {
 362+ var pixelHeightDim = 'height';
 363+ var pixelWidthDim = 'width';
 364+ // this must be called after orientation is set above. If no orientation set, defaults to 0
 365+ var degrees = this.getOrientationDegrees();
 366+ // jpegmeta reports pixelHeight & width
 367+ if ( degrees == 90 || degrees == 270 ) {
 368+ pixelHeightDim = 'width';
 369+ pixelWidthDim = 'height';
 370+ }
362371 if ( meta.general.pixelHeight ) {
363 - this.imageinfo.height = meta.general.pixelHeight.value;
 372+ this.imageinfo[pixelHeightDim] = meta.general.pixelHeight.value;
364373 }
365374 if ( meta.general.pixelWidth ) {
366 - this.imageinfo.width = meta.general.pixelWidth.value;
 375+ this.imageinfo[pixelWidthDim] = meta.general.pixelWidth.value;
367376 }
368377 }
369378 }

Sign-offs

UserFlagDate
Brion VIBBERtested22:34, 21 September 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r981521.18wmf1: MFT r93912, r95318, r97403, r97650, r97657, r97661, r97687, r97777catrope18:13, 26 September 2011
r98759MFT r92930, r96665, r97650, r97701, r97702, r97733, r97794, r97892reedy13:31, 3 October 2011

Status & tagging log