r97403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97402‎ | r97403 | r97404 >
Date:04:25, 18 September 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
(bug 18424) Clean up paging links on Special:allpages and special:prefixindex.

*Make them normal font size (my eyes! my eyes! with the tiny writing)
*Special:prefindex needs a paging link on the bottom like special:allpages (added a class name here, because I couldn't use the existing id on both)
*special:prefindex was doing $wgLang->pipeList( "full html table here", "next link here" ) which was giving bad output for the obvious reason.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.css (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -92,6 +92,8 @@
9393 * Allowing moving the associated talk pages of subpages even if the base page
9494 has no subpage.
9595 * (bug 30907) Special:Unusedcategories should sort ascendingly.
 96+* (bug 18424) Special:Prefixindex and Special:Allpages paging links are
 97+ really small, and somewhat inconsistent with each other.
9698
9799 === API changes in 1.19 ===
98100 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
@@ -197,6 +197,7 @@
198198 }
199199 }
200200
 201+ $footer = '';
201202 if ( $this->including() ) {
202203 $out2 = '';
203204 } else {
@@ -207,7 +208,7 @@
208209 <td>' .
209210 $nsForm .
210211 '</td>
211 - <td id="mw-prefixindex-nav-form">';
 212+ <td id="mw-prefixindex-nav-form" class="mw-prefixindex-nav">';
212213
213214 if( isset( $res ) && $res && ( $n == $this->maxPerPage ) && ( $s = $res->fetchObject() ) ) {
214215 $query = array(
@@ -219,20 +220,21 @@
220221 $query['namespace'] = $namespace;
221222 }
222223
223 - $out2 = $this->getLang()->pipeList( array(
224 - $out2,
225 - Linker::linkKnown(
 224+ $nextLink = Linker::linkKnown(
226225 $self,
227226 wfMsgHtml( 'nextpage', str_replace( '_',' ', htmlspecialchars( $s->page_title ) ) ),
228227 array(),
229228 $query
230 - )
231 - ) );
 229+ );
 230+ $out2 .= $nextLink;
 231+
 232+ $footer = "\n" . Html::element( "hr" )
 233+ . Html::rawElement( "div", array( "class" => "mw-prefixindex-nav" ), $nextLink );
232234 }
233235 $out2 .= "</td></tr>" .
234236 Xml::closeElement( 'table' );
235237 }
236238
237 - $this->getOutput()->addHTML( $out2 . $out );
 239+ $this->getOutput()->addHTML( $out2 . $out . $footer );
238240 }
239241 }
Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.css
@@ -25,7 +25,6 @@
2626 }
2727 .mw-allpages-nav {
2828 text-align: right;
29 - font-size: smaller;
3029 margin-bottom: 1em;
3130 }
3231 table.mw-allpages-table-form tr {
@@ -72,11 +71,12 @@
7372 width: 98%;
7473 }
7574 td#mw-prefixindex-nav-form {
76 - font-size: smaller;
7775 margin-bottom: 1em;
78 - text-align: right;
7976 vertical-align: top;
8077 }
 78+.mw-prefixindex-nav {
 79+ text-align: right;
 80+}
8181
8282
8383 /**** Special:Search ****/

Follow-up revisions

RevisionCommit summaryAuthorDate
r981521.18wmf1: MFT r93912, r95318, r97403, r97650, r97657, r97661, r97687, r97777catrope18:13, 26 September 2011
r984521.18: MFT r97403, r97614, r97657, r97661reedy21:10, 29 September 2011
r98453Followup r98452, move RELEASE-NOTES from r97403reedy21:11, 29 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88084(bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all p...btongminh14:15, 14 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   10:27, 18 September 2011

Looks little better now.

#Comment by Bawolff (talk | contribs)   19:42, 18 September 2011

Part of this is fixing an extra | character that appears for no reason (It used to separate the link to allpages which was removed) which is a regression in 1.18 (from r88084). I imagine this is too late for 1.18 though(?)

#Comment by Bawolff (talk | contribs)   13:51, 22 September 2011

I'm tagging this 1.18 and 1.18wmf1 on the basis of the extra | by the paging links in things like [1] (regression in 1.18) which this fixes.

Status & tagging log