r97649 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97648‎ | r97649 | r97650 >
Date:18:56, 20 September 2011
Author:laner
Status:deferred
Tags:
Comment:
Don't wrap variables in quotes, since it breaks puppet
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaHost.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaHost.php
@@ -635,7 +635,7 @@
636636 $hostEntry['puppetclass'][] = $class;
637637 }
638638 foreach ( $wgOpenStackManagerPuppetOptions['defaultvariables'] as $variable => $value ) {
639 - $hostEntry['puppetvar'][] = $variable . '="' . $value . '"';
 639+ $hostEntry['puppetvar'][] = $variable . '=' . $value;
640640 }
641641 if ( $puppetinfo ) {
642642 if ( isset( $puppetinfo['classes'] ) ) {
@@ -646,7 +646,7 @@
647647 if ( isset( $puppetinfo['variables'] ) ) {
648648 foreach ( $puppetinfo['variables'] as $variable => $value ) {
649649 if ( $value ) {
650 - $hostEntry['puppetvar'][] = $variable . '="' . $value . '"';
 650+ $hostEntry['puppetvar'][] = $variable . '=' . $value;
651651 }
652652 }
653653 }

Status & tagging log