r92930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92929‎ | r92930 | r92931 >
Date:02:54, 23 July 2011
Author:neilk
Status:ok
Tags:
Comment:
fix problem with php 5.3 -- $msg is ultimately used in call_user_func_array, so it must be an array, or it will generate a warning. PHP 5.2 does not give this warning, which is why we do not see it in production yet.
Modified paths:
  • /trunk/extensions/WikimediaMessages/WikimediaMessages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaMessages/WikimediaMessages.php
——@@ -37,7 +37,7 @@
3838 }
3939
4040 function efWikimediaEditPageCopyrightWarning( $title, &$msg ) {
41 - $msg = 'wikimedia-copyrightwarning';
 41+ $msg = array( 'wikimedia-copyrightwarning' );
4242 return true;
4343 }
4444

Follow-up revisions

RevisionCommit summaryAuthorDate
r954111.17wmf1: MFT r92930catrope18:37, 24 August 2011
r977301.18wmf1: MFT r92930catrope13:41, 21 September 2011
r98759MFT r92930, r96665, r97650, r97701, r97702, r97733, r97794, r97892reedy13:31, 3 October 2011

Status & tagging log