r97661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97660‎ | r97661 | r97662 >
Date:20:40, 20 September 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Fixed IE6 issues in RTL mode
Modified paths:
  • /trunk/phase3/skins/monobook/IE60Fixes.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE60Fixes.css
@@ -11,17 +11,34 @@
1212 margin-top: 3em;
1313 height: 1%;
1414 }
 15+.rtl div#column-content div#content {
 16+ margin-right: 12.2em;
 17+ margin-left: 0;
 18+}
1519 div#column-one {
1620 position: absolute;
1721 top: 0;
1822 left: 0;
1923 z-index: 4;
2024 }
 25+.rtl div#column-one {
 26+ left: auto;
 27+ right: 0;
 28+}
2129 div#footer {
2230 margin-left: 13.6em;
2331 border-left: 1px solid #fabd23;
2432 }
 33+.rtl div#footer {
 34+ margin-left: 0;
 35+ margin-right: 13.6em;
 36+ border-left: none;
 37+ border-right: 1px solid #fabd23;
 38+}
2539
 40+ /* the tabs */
 41+
 42+
2643 /* the tabs */
2744
2845 #p-cactions {

Follow-up revisions

RevisionCommit summaryAuthorDate
r97668Cleaned up leftovers from applying a patchtparscal21:41, 20 September 2011
r981521.18wmf1: MFT r93912, r95318, r97403, r97650, r97657, r97661, r97687, r97777catrope18:13, 26 September 2011
r984521.18: MFT r97403, r97614, r97657, r97661reedy21:10, 29 September 2011

Comments

#Comment by Jack Phoenix (talk | contribs)   21:09, 20 September 2011
+ /* the tabs */
+
+
 /* the tabs */

Whoops?

#Comment by Trevor Parscal (WMF) (talk | contribs)   21:42, 20 September 2011

Good catch - sorted in r97668

#Comment by Brion VIBBER (talk | contribs)   21:45, 21 September 2011

Here's a screenshot of the awfulness that this fixes, for reference :)

Screenshot for rev 97661.png

Status & tagging log