r96665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96664‎ | r96665 | r96666 >
Date:14:49, 9 September 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Use static Linker, fixes Fatal error: Call to a member function link() on a non-object in SpecialCite.php, when using monobook skin
Modified paths:
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/SpecialCite.php
@@ -59,17 +59,15 @@
6060 * @return bool
6161 */
6262 function wfSpecialCiteToolbox( &$skin ) {
63 - global $wgUser;
64 -
6563 if ( isset( $skin->data['nav_urls']['cite'] ) ) {
6664 echo Html::rawElement(
6765 'li',
6866 array( 'id' => 't-cite' ),
69 - $skin->skin->link(
 67+ Linker::link(
7068 SpecialPage::getTitleFor( 'Cite' ),
7169 wfMsg( 'cite_article_link' ),
7270 # Used message keys: 'tooltip-cite-article', 'accesskey-cite-article'
73 - $wgUser->getSkin()->tooltipAndAccessKeyAttribs( 'cite-article' ),
 71+ Linker::tooltipAndAccessKeyAttribs( 'cite-article' ),
7472 $skin->data['nav_urls']['cite']['args']
7573 )
7674 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r98759MFT r92930, r96665, r97650, r97701, r97702, r97733, r97794, r97892reedy13:31, 3 October 2011

Comments

#Comment by SPQRobin (talk | contribs)   14:54, 9 September 2011

I thought this would need to go to 1.18 as well, but I don't get the fatal error on the 1.18 branch...

Status & tagging log