r97404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97403‎ | r97404 | r97405 >
Date:04:50, 18 September 2011
Author:krinkle
Status:resolved
Tags:
Comment:
Move the mediawiki.test.bug30825.js helper script out of the /suites/ directory into /data/ and rename to be more re-usable.
(Follows-up r96680)
Modified paths:
  • /trunk/phase3/tests/qunit/data/qunitOkCall.js (added) (history)
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js (deleted) (history)
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/data/qunitOkCall.js
@@ -0,0 +1,2 @@
 2+start();
 3+ok( true, 'Successfully loaded!');
Property changes on: trunk/phase3/tests/qunit/data/qunitOkCall.js
___________________________________________________________________
Added: svn:eol-style
14 + native
Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.bug30825.js
@@ -1,2 +0,0 @@
2 -start();
3 -ok( true, "Bug 30825 -- protocol-relative URL script load via mw.loader.load");
Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -178,7 +178,7 @@
179179 // Confirm that mw.loader.load() works with protocol-relative URLs
180180 var loc = window.location,
181181 base = ('//' + loc.hostname + loc.pathname).replace(/\/[^\/]*$/, ''),
182 - target = base + '/suites/resources/mediawiki/mediawiki.test.bug30825.js';
 182+ target = base + '/data/qunitOkCall.js?' + (new Date()).getTime();
183183
184184 // Async! Include a timeout, as failure in this test leads to neither the
185185 // success nor failure callbacks getting called.

Follow-up revisions

RevisionCommit summaryAuthorDate
r101356fix mediawiki.test wrong URL...hashar13:53, 31 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96679MFT r87986 -- consolidation of addScript in mediawiki.loader, also fixes bug ...brion18:39, 9 September 2011
r96680Followup r87986: qunit test case for bug 30825...brion18:43, 9 September 2011
r96699Provisional workaround for bug 30825 as it affects things run via $.ajax() us...brion22:03, 9 September 2011

Status & tagging log