r88084 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88083‎ | r88084 | r88085 >
Date:14:15, 14 May 2011
Author:btongminh
Status:ok
Tags:
Comment:
(bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all pages.
Removed All pages link which doesn't make sense
Patch by Salvatore Ingala

Put ST47 on the proper place in CREDITS
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -35,6 +35,8 @@
3636 the user a page named [[:]] already exists.
3737 * (bug 28960) Added more messages to Special:EmailUser.
3838 * (bug 23002) Imagelinks table not updated after imagemove.
 39+* (bug 27864) Transcluding {{Special:Prefix}} with empty prefix now lists all
 40+ pages.
3941
4042 === API changes in 1.19 ===
4143 * (bug 27790) add query type for querymodules to action=paraminfo
Index: trunk/phase3/CREDITS
@@ -134,10 +134,11 @@
135135 * René Kijewski
136136 * Robert Treat
137137 * RockMFR
138 -* ST47
 138+* Salvatore Ingala
139139 * Scott Colcord
140140 * Simon Walker
141141 * Solitarius
 142+* ST47
142143 * Stefano Codari
143144 * Str4nd
144145 * svip
Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
@@ -56,7 +56,10 @@
5757 );
5858
5959 $showme = '';
60 - if( isset( $par ) ){
 60+ if ( $this->including() && ( $par == '' ) ) {
 61+ // Bug 27864: if transcluded, show all pages instead of the form
 62+ $showme = ' ';
 63+ } elseif( isset( $par ) ){
6164 $showme = $par;
6265 } elseif( $prefix != '' ){
6366 $showme = $prefix;
@@ -201,8 +204,7 @@
202205 <td>' .
203206 $nsForm .
204207 '</td>
205 - <td id="mw-prefixindex-nav-form">' .
206 - $sk->linkKnown( $self, wfMsgHtml( 'allpages' ) );
 208+ <td id="mw-prefixindex-nav-form">';
207209
208210 if( isset( $res ) && $res && ( $n == $this->maxPerPage ) && ( $s = $res->fetchObject() ) ) {
209211 $query = array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r90692Minor code cleanupsaaron07:08, 24 June 2011
r90724* More cleanups for r88084 (and fixed r90692)....aaron19:22, 24 June 2011
r97403(bug 18424) Clean up paging links on Special:allpages and special:prefixindex....bawolff04:25, 18 September 2011

Status & tagging log