r97402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97401‎ | r97402 | r97403 >
Date:04:07, 18 September 2011
Author:pgehres
Status:ok
Tags:
Comment:
Fixing relative links per r97182. Fixing css includes per r97009. Adding images referenced in css to local.
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/Webitects.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/lp1.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1a.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-green.gif (added) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-white.gif (added) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1.html
@@ -201,8 +201,8 @@
202202 </div>
203203 </div>
204204
205 - <p>We do not store your credit card information, and your personal data is subject to our <a target="_blank" href="http://wikimediafoundation.org/wiki/Donor_policy"> donor privacy policy</a>.</p>
206 - <p><a href="https://www.mediawiki.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
 205+ <p>We do not store your credit card information, and your personal data is subject to our <a target="_blank" href="https://www.mediawiki.org//wikimediafoundation.org/wiki/Donor_policy"> donor privacy policy</a>.</p>
 206+ <p><a href="https://www.mediawiki.org//wikimediafoundation.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org//wikimediafoundation.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
207207 </div>
208208 </div>
209209 <!-- load jquery (newer) -->
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_1a.html
@@ -202,8 +202,8 @@
203203 <p><strong>People:</strong> The other top 10 website have thousands of employees. We have fewer than 100, making your donation a great investment in a highly-efficient not-for-profit organization.</p>
204204 </div>
205205
206 - <p>We do not store your credit card information, and your personal data is subject to our <a target="_blank" href="http://wikimediafoundation.org/wiki/Donor_policy"> donor privacy policy</a>.</p>
207 - <p><a href="https://www.mediawiki.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
 206+ <p>We do not store your credit card information, and your personal data is subject to our <a target="_blank" href="https://www.mediawiki.org//wikimediafoundation.org/wiki/Donor_policy"> donor privacy policy</a>.</p>
 207+ <p><a href="https://www.mediawiki.org//wikimediafoundation.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org//wikimediafoundation.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
208208 </div>
209209 </div>
210210 <!-- load jquery (newer) -->
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/webitects_2.html
@@ -211,8 +211,8 @@
212212 </div>
213213 </div>
214214 </div>
215 - <p>We do not store your credit card information, and your personal data is subject to our <a target="_blank" href="http://wikimediafoundation.org/wiki/Donor_policy"> donor privacy policy</a>.</p>
216 -<p><a href="https://www.mediawiki.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
 215+ <p>We do not store your credit card information, and your personal data is subject to our <a target="_blank" href="https://www.mediawiki.org//wikimediafoundation.org/wiki/Donor_policy"> donor privacy policy</a>.</p>
 216+<p><a href="https://www.mediawiki.org//wikimediafoundation.org/wiki/Ways_to_Give/en">More information or other ways to give</a><br /><a href="https://www.mediawiki.org//wikimediafoundation.org/wiki/FAQ/en">Answers to frequently asked questions</a></p>
217217 </div>
218218 </div>
219219
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-green.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-green.gif
___________________________________________________________________
Added: svn:mime-type
220220 + image/gif
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-white.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-white.gif
___________________________________________________________________
Added: svn:mime-type
221221 + image/gif
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/Webitects.css
@@ -16,12 +16,12 @@
1717 .call-l { float: left; margin: 0.2em 1em 1em 0; }
1818 .call-l, .call-r { background: #fff; border: 1px solid #444; font-size: 13px; padding: 15px 20px; }
1919 .call-l h3, .call-r h3 { font-size: 17px; }
20 -.call-l .loading, .call-r .loading { background-image: url(../images/loading-white.gif); }
 20+.call-l .loading, .call-r .loading { background-image: url(https://payments.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-white.gif); }
2121 .call-r { float: right; margin: 0.2em 0 1em 1em; }
2222
2323 /* Loading */
2424 #loading { font-size: 12px; margin-left: 0.5em; vertical-align: middle; }
25 -.loading { background: url(../images/loading-green.gif) no-repeat 50% 50%; padding: 10px; }
 25+.loading { background: url(https://payments.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/images/loading-green.gif) no-repeat 50% 50%; padding: 10px; }
2626
2727 /* Muted text */
2828 .mute { font-size: 12px; }
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/lp1.css
@@ -1,7 +1,7 @@
22 /* Pitch */
33 #pitch {
44 height: 236px;
5 - background-image: url(http://upload.wikimedia.org/wikipedia/foundation/d/dc/Jimmy_Appeal_2009.jpg);
 5+ background-image: none;
66 background-position: right top;
77 background-repeat: no-repeat;
88 background-color: #1e1e1e;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97009Adding new RapidHTML forms (including css/js folders)pgehres22:00, 13 September 2011
r97182adding webitects_1a; ready for testingpgehres18:11, 15 September 2011

Status & tagging log