r100371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100370‎ | r100371 | r100372 >
Date:20:50, 20 October 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r93977, r98884, e98963, e98975
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/SkinLegacy.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiExpandTemplates.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialBlock.php (modified) (history)
  • /branches/REL1_18/phase3/languages (modified) (history)
  • /branches/REL1_18/phase3/languages/Names.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/api/ApiExpandTemplates.php
@@ -90,7 +90,10 @@
9191 'title' => array(
9292 ApiBase::PARAM_DFLT => 'API',
9393 ),
94 - 'text' => null,
 94+ 'text' => array(
 95+ ApiBase::PARAM_TYPE => 'string',
 96+ ApiBase::PARAM_REQUIRED => true,
 97+ ),
9598 'generatexml' => false,
9699 'includecomments' => false,
97100 );
Property changes on: branches/REL1_18/phase3/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
98101 Merged /trunk/phase3/includes/api:r93977,98884,98963,98975
Index: branches/REL1_18/phase3/includes/SkinLegacy.php
@@ -66,10 +66,10 @@
6767 }
6868
6969 class LegacyTemplate extends BaseTemplate {
70 -
 70+
7171 // How many search boxes have we made? Avoid duplicate id's.
7272 protected $searchboxes = '';
73 -
 73+
7474 function execute() {
7575 $this->html( 'headelement' );
7676 echo $this->beforeContent();
@@ -80,7 +80,7 @@
8181 $this->printTrail();
8282 echo "\n</body></html>";
8383 }
84 -
 84+
8585 /**
8686 * This will be called immediately after the <body> tag. Split into
8787 * two functions to make it easier to subclass.
@@ -484,7 +484,7 @@
485485
486486 if ( $image ) {
487487 $link = htmlspecialchars( $image->getURL() );
488 - $style = $this->getInternalLinkAttributes( $link, $name );
 488+ $style = Linker::getInternalLinkAttributes( $link, $name );
489489 $s[] = "<a href=\"{$link}\"{$style}>{$name}</a>";
490490 }
491491 }
Index: branches/REL1_18/phase3/includes/specials/SpecialBlock.php
@@ -503,7 +503,7 @@
504504 list( $ip, $range ) = explode( '/', $target, 2 );
505505
506506 if( ( IP::isIPv4( $ip ) && $wgBlockCIDRLimit['IPv4'] == 32 )
507 - || ( IP::isIPv6( $ip ) && $wgBlockCIDRLimit['IPV6'] == 128 ) )
 507+ || ( IP::isIPv6( $ip ) && $wgBlockCIDRLimit['IPv6'] == 128 ) )
508508 {
509509 # Range block effectively disabled
510510 return wfMessage( 'range_block_disabled' );
Property changes on: branches/REL1_18/phase3/includes/specials/SpecialBlock.php
___________________________________________________________________
Modified: svn:mergeinfo
511511 Merged /trunk/phase3/includes/specials/SpecialBlock.php:r98975
Property changes on: branches/REL1_18/phase3/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
512512 Merged /trunk/phase3/includes/specials:r98975
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
513513 Merged /trunk/phase3/includes:r93977,98884,98963,98975
Index: branches/REL1_18/phase3/languages/Names.php
@@ -148,7 +148,7 @@
149149 'it' => 'Italiano', # Italian
150150 'iu' => 'ᐃᓄᒃᑎᑐᑦ/inuktitut', # Inuktitut (macro language - do no localise, see ike/ikt - falls back to ike-cans)
151151 'ja' => '日本語', # Japanese
152 - 'jam' => 'Patios', # Jamaican Creole English
 152+ 'jam' => 'Patois', # Jamaican Creole English
153153 'jbo' => 'Lojban', # Lojban
154154 'jut' => 'Jysk', # Jutish / Jutlandic
155155 'jv' => 'Basa Jawa', # Javanese
Property changes on: branches/REL1_18/phase3/languages
___________________________________________________________________
Modified: svn:mergeinfo
156156 Merged /trunk/phase3/languages:r98884,98963,98975
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
157157 Merged /trunk/phase3:r93977,98884,98963,98975

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93977Followup r93905 per comment on bug 30230...reedy14:55, 5 August 2011
r98884Fix language name for 'jam'robin18:59, 4 October 2011

Status & tagging log