r88118 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88117‎ | r88118 | r88119 >
Date:22:10, 14 May 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
Fix Bug 28979 — “remove some CSS for abbr and acronym tags”

The <abbr> and <acronym> tags were whitelisted with bug 671, but
there are some CSS rules for them since long, long times. They can
be found in the first versions of chick, monobook and are carried
on to vector skin.

Often these tags are used in links, e.g. [[Normalnull|<abbr
title="meter above see level">NN</abbr>]]. But in here the
color:black; makes the text unrecognizable as a hyperlink
(together with the senseful cursor:help; rule).

When these rules where meant to override some crazy
browserdependent default settings, they should be be changed to
"inherit".

from Bergi
Modified paths:
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
——@@ -146,12 +146,6 @@
147147 color: black;
148148 vertical-align: top;
149149 }
150 -abbr, acronym, .explain {
151 - border-bottom: 1px dotted black;
152 - color: black;
153 - background: none;
154 - cursor: help;
155 -}
156150 q {
157151 font-family: Times, "Times New Roman", serif;
158152 font-style: italic;
Index: trunk/phase3/skins/common/shared.css
——@@ -4,6 +4,12 @@
55 * another, but don't ignore the poor pre-Monobook users either.
66 */
77
 8+/* Default style for semantic tags */
 9+abbr, acronym, .explain {
 10+ border-bottom: 1px dotted black;
 11+ cursor: help;
 12+}
 13+
814 /* Colored watchlist and recent changes numbers */
915 .mw-plusminus-pos { color: #006400; } /* dark green */
1016 .mw-plusminus-neg { color: #8b0000; } /* dark red */
Index: trunk/phase3/skins/vector/screen.css
——@@ -765,16 +765,8 @@
766766 margin: .4em 0 .5em 0;
767767 line-height: 1.5em;
768768 }
769 - p img {
770 - margin: 0;
771 - }
772 -abbr,
773 -acronym,
774 -.explain {
775 - border-bottom: 1px dotted black;
776 - color: black;
777 - background: none;
778 - cursor: help;
 769+p img {
 770+ margin: 0;
779771 }
780772 q {
781773 font-family: Times, "Times New Roman", serif;

Sign-offs

UserFlagDate
Hasharinspected09:31, 21 May 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r88498Followup r88118. Fix Bug 28979 — “remove some CSS for abbr and acronym...mah22:27, 20 May 2011
r896701.17wmf1: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451catrope18:39, 7 June 2011
r896711.17wmf1: Revert r89670, merged revs were intended for REL1_17 instead. This ...catrope18:41, 7 June 2011
r896721.17: Redo r89670 in the right branch: MFT r87423, r88118, r88124, r88211, r8...catrope18:45, 7 June 2011
r90258MFT r87586, r87840, r88085, r88118, r88124, r88492, r88498tstarling04:46, 17 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54241Allow <abbr> in wikitext...simetrical22:15, 2 August 2009
r73880More bug 671: whitelist <kbd> and <samp> for user input. Followup per r70164'...demon11:12, 28 September 2010

Comments

#Comment by Fomafix (talk | contribs)   15:32, 11 January 2012 
border-bottom: 1px dotted black;

should be replaced by 

border-bottom: 1px dotted;

to get a border in the same color like the current text color:

  1. red text with border-bottom: 1px dotted black.
  2. red text with border-bottom: 1px dotted.
#Comment by Fomafix (talk | contribs)   17:34, 13 January 2012

Reported as Bug 33703.

Further examples:

red on black: border-bottom: 1px dotted black, border-bottom: 1px dotted.
red on white: border-bottom: 1px dotted black, border-bottom: 1px dotted.
white on black: border-bottom: 1px dotted black, border-bottom: 1px dotted.

Status & tagging log