r89099 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89098‎ | r89099 | r89100 >
Date:13:22, 29 May 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Fix message key for account creation by e-mail.
'noemail' => 'There is no e-mail address recorded for user "$1".' is misleading/wrong.
The long existing message 'noemailcreate' => 'You need to provide a valid e-mail address' is unused. No idea what happened in the past.
Needs merging to 1.17, 1.18
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -158,7 +158,7 @@
159159 global $wgOut;
160160
161161 if ( $this->mEmail == '' ) {
162 - $this->mainLoginForm( wfMsgExt( 'noemail', array( 'parsemag', 'escape' ), $this->mUsername ) );
 162+ $this->mainLoginForm( wfMsgExt( 'noemailcreate', array( 'parsemag', 'escape' ), $this->mUsername ) );
163163 return;
164164 }
165165

Follow-up revisions

RevisionCommit summaryAuthorDate
r89108Followup r89099 per RobertL's CR: Remove now unused parameter. Thanks :)raymond14:53, 29 May 2011
r896701.17wmf1: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451catrope18:39, 7 June 2011
r896711.17wmf1: Revert r89670, merged revs were intended for REL1_17 instead. This ...catrope18:41, 7 June 2011
r896721.17: Redo r89670 in the right branch: MFT r87423, r88118, r88124, r88211, r8...catrope18:45, 7 June 2011
r91758MFT to REL1_18:...hashar21:26, 8 July 2011

Comments

#Comment by RobertL (talk | contribs)   14:45, 29 May 2011

Can the $this->mUsername parameter be removed now that it is unused?

#Comment by Hashar (talk | contribs)   08:15, 6 June 2011

Thanks for the review RobertL :-)

Status & tagging log