r88117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88116‎ | r88117 | r88118 >
Date:22:06, 14 May 2011
Author:freakolowsky
Status:reverted (Comments)
Tags:
Comment:
* added alternative revison size display if diff size is not selected
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -571,7 +571,8 @@
572572 $fields = array(
573573 'page_namespace', 'page_title', 'page_is_new', 'page_latest', 'page_is_redirect',
574574 'page_len','rev_id', 'rev_page', 'rev_text_id', 'rev_timestamp', 'rev_comment',
575 - 'rev_minor_edit', 'rev_user', 'rev_user_text', 'rev_parent_id', 'rev_deleted'
 575+ 'rev_minor_edit', 'rev_user', 'rev_user_text', 'rev_parent_id', 'rev_deleted',
 576+ 'rev_len'
576577 );
577578 if ( $this->showSizeDiff && !$wgMiserMode ) {
578579 $fields = array_merge( $fields, array( 'rc_old_len', 'rc_new_len' ) );
@@ -761,7 +762,7 @@
762763 $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
763764
764765
765 - $diffOut = ( $this->showSizeDiff ) ? ' . . '.ChangesList::showCharacterDifference( $row->rc_old_len, $row->rc_new_len ) : '';
 766+ $diffOut = ( $this->showSizeDiff ) ? ' . . '.ChangesList::showCharacterDifference( $row->rc_old_len, $row->rc_new_len ) : ' . . '.Linker::formatRevisionSize( $row->rev_len );
766767
767768 $ret = "{$del}{$d} {$diffHistLinks} {$nflag}{$mflag} {$link}{$diffOut}{$userlink} {$comment} {$topmarktext}";
768769

Follow-up revisions

RevisionCommit summaryAuthorDate
r95496Revert r8811...reedy17:35, 25 August 2011
r96306Revert r88008 (add size difference to Special:Contributions) and its large gr...catrope21:47, 5 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88111* added an option to toggle the display of diff size with a warning message....freakolowsky17:05, 14 May 2011

Comments

#Comment by Freakolowsky (talk | contribs)   22:12, 14 May 2011

Still think we need a more consistent way of displaying the size ... either display both with "bytes" suffix or both without ... but that's just an opinion.

Status & tagging log