r88124 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88123‎ | r88124 | r88125 >
Date:23:11, 14 May 2011
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Add Rotem Liss and Platonides to author list.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
——@@ -109,7 +109,7 @@
110110 'Aryeh Gregor', 'Aaron Schulz', 'Andrew Garrett', 'Raimond Spekking',
111111 'Alexandre Emsenhuber', 'Siebrand Mazeland', 'Chad Horohoe',
112112 'Roan Kattouw', 'Trevor Parscal', 'Bryan Tong Minh', 'Sam Reed',
113 - 'Victor Vasiliev',
 113+ 'Victor Vasiliev', 'Rotem Liss', 'Platonides',
114114 wfMsg( 'version-poweredby-others' )
115115 );
116116

Follow-up revisions

RevisionCommit summaryAuthorDate
r89451Followup r88124: fix the most glaring bug of the weekdemon02:54, 4 June 2011
r896701.17wmf1: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451catrope18:39, 7 June 2011
r896711.17wmf1: Revert r89670, merged revs were intended for REL1_17 instead. This ...catrope18:41, 7 June 2011
r896721.17: Redo r89670 in the right branch: MFT r87423, r88118, r88124, r88211, r8...catrope18:45, 7 June 2011
r90258MFT r87586, r87840, r88085, r88118, r88124, r88492, r88498tstarling04:46, 17 June 2011

Comments

#Comment by Bryan (talk | contribs)   08:34, 15 May 2011

I fully agree with Platonides being added to the author list, but I do think that the authors list should contain real names.

#Comment by Siebrand (talk | contribs)   10:47, 15 May 2011

This is what he said his name was, so that's the name I added.

#Comment by Platonides (talk | contribs)   20:33, 19 May 2011

That's not how I remember that talk.

#Comment by Siebrand (talk | contribs)   23:22, 19 May 2011

(avoidable roundtrip) How do you remember it?

#Comment by Hashar (talk | contribs)   20:22, 2 June 2011

What is that list for? It can not be the MediaWiki author list since I am not listed in the array: 

'Erik Möller', 'Gabriel Wicke'  <-- see? No 'Ashar Voultoiz'
#Comment by Bryan (talk | contribs)   21:11, 2 June 2011

The cabal decided that you broke too many things, so your existence was erased from history ;)


Seriously though. this is really odd. I do remember seeing your name there, but a quick look in the history shows you have never been there. You are in README though...

#Comment by Hashar (talk | contribs)   06:21, 3 June 2011

Bryan> there is no cabal  ;-)

IIRC, we only wanted real names in Special:Version while a pseudonym/nickname would be fine in the text files. I haven't found the policy or email though.

Status & tagging log