r89672 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89671‎ | r89672 | r89673 >
Date:18:45, 7 June 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17: Redo r89670 in the right branch: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451
Modified paths:
  • /branches/REL1_17/phase3/includes/api/ApiParse.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/REL1_17/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /branches/REL1_17/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /branches/REL1_17/phase3/resources/Resources.php (modified) (history)
  • /branches/REL1_17/phase3/skins/chick/main.css (modified) (history)
  • /branches/REL1_17/phase3/skins/common/shared.css (modified) (history)
  • /branches/REL1_17/phase3/skins/monobook/main.css (modified) (history)
  • /branches/REL1_17/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/skins/chick/main.css
@@ -146,12 +146,6 @@
147147 color: black;
148148 vertical-align: top;
149149 }
150 -abbr, acronym, .explain {
151 - border-bottom: 1px dotted black;
152 - color: black;
153 - background: none;
154 - cursor: help;
155 -}
156150 q {
157151 font-family: Times, "Times New Roman", serif;
158152 font-style: italic;
Index: branches/REL1_17/phase3/skins/monobook/main.css
@@ -195,12 +195,6 @@
196196 select {
197197 vertical-align: top;
198198 }
199 -abbr, acronym, .explain {
200 - border-bottom: 1px dotted black;
201 - color: black;
202 - background: none;
203 - cursor: help;
204 -}
205199 q {
206200 font-family: Times, "Times New Roman", serif;
207201 font-style: italic;
Index: branches/REL1_17/phase3/skins/common/shared.css
@@ -4,6 +4,12 @@
55 * another, but don't ignore the poor non-Monobook users either.
66 */
77
 8+/* Default style for semantic tags */
 9+abbr, acronym, .explain {
 10+ border-bottom: 1px dotted black;
 11+ cursor: help;
 12+}
 13+
814 /* Colored watchlist and recent changes numbers */
915 .mw-plusminus-pos { color: #006400; } /* dark green */
1016 .mw-plusminus-neg { color: #8b0000; } /* dark red */
Property changes on: branches/REL1_17/phase3/skins/common/shared.css
___________________________________________________________________
Modified: svn:mergeinfo
1117 Merged /trunk/phase3/skins/common/shared.css:r87423,88118,88124,88211,88498,89099,89401,89451
Index: branches/REL1_17/phase3/skins/vector/screen.css
@@ -754,16 +754,8 @@
755755 margin: .4em 0 .5em 0;
756756 line-height: 1.5em;
757757 }
758 - p img {
759 - margin: 0;
760 - }
761 -abbr,
762 -acronym,
763 -.explain {
764 - border-bottom: 1px dotted black;
765 - color: black;
766 - background: none;
767 - cursor: help;
 758+p img {
 759+ margin: 0;
768760 }
769761 q {
770762 font-family: Times, "Times New Roman", serif;
Property changes on: branches/REL1_17/phase3/skins/vector/screen.css
___________________________________________________________________
Modified: svn:mergeinfo
771763 Merged /trunk/phase3/skins/vector/screen.css:r87423,88118,88124,88211,88498,89099,89401,89451
Index: branches/REL1_17/phase3/includes/installer/Installer.i18n.php
@@ -427,7 +427,7 @@
428428 'config-upload-deleted-help' => 'Choose a directory in which to archive deleted files.
429429 Ideally, this should not be accessible from the web.',
430430 'config-logo' => 'Logo URL:',
431 - 'config-logo-help' => "MediaWiki's default skin includes space for a 135x160 pixel logo in the top left corner.
 431+ 'config-logo-help' => "MediaWiki's default skin includes space for a 135x160 pixel logo above the sidebar menu.
432432 Upload an image of the appropriate size, and enter the URL here.
433433
434434 If you do not want a logo, leave this box blank.",
Property changes on: branches/REL1_17/phase3/includes/installer/Installer.i18n.php
___________________________________________________________________
Modified: svn:mergeinfo
435435 Merged /trunk/phase3/includes/installer/Installer.i18n.php:r87423,88118,88124,88211,88498,89099,89401,89451
Index: branches/REL1_17/phase3/includes/api/ApiParse.php
@@ -516,7 +516,6 @@
517517 ' headhtml - Gives parsed <head> of the page',
518518 ' iwlinks - Gives interwiki links in the parsed wikitext',
519519 ' wikitext - Gives the original wikitext that was parsed',
520 - 'NOTE: Section tree is only generated if there are more than 4 sections, or if the __TOC__ keyword is present'
521520 ),
522521 'pst' => array(
523522 'Do a pre-save transform on the input before parsing it',
Property changes on: branches/REL1_17/phase3/includes/api/ApiParse.php
___________________________________________________________________
Modified: svn:mergeinfo
524523 Merged /trunk/phase3/includes/api/ApiParse.php:r87423,88118,88124,88211,88498,89099,89401,89451
Index: branches/REL1_17/phase3/includes/specials/SpecialUserlogin.php
@@ -148,7 +148,7 @@
149149 global $wgOut;
150150
151151 if ( $this->mEmail == '' ) {
152 - $this->mainLoginForm( wfMsgExt( 'noemail', array( 'parsemag', 'escape' ), $this->mName ) );
 152+ $this->mainLoginForm( wfMsgExt( 'noemailcreate', array( 'parsemag', 'escape' ), $this->mName ) );
153153 return;
154154 }
155155
Index: branches/REL1_17/phase3/includes/specials/SpecialVersion.php
@@ -103,6 +103,7 @@
104104 'Aryeh Gregor', 'Aaron Schulz', 'Andrew Garrett', 'Raimond Spekking',
105105 'Alexandre Emsenhuber', 'Siebrand Mazeland', 'Chad Horohoe',
106106 'Roan Kattouw', 'Trevor Parscal', 'Bryan Tong Minh', 'Sam Reed',
 107+ 'Victor Vasiliev', 'Rotem Liss', 'Platonides', 'Ashar Voultoiz',
107108 wfMsg( 'version-poweredby-others' )
108109 );
109110
Property changes on: branches/REL1_17/phase3/includes/specials/SpecialVersion.php
___________________________________________________________________
Modified: svn:mergeinfo
110111 Merged /trunk/phase3/includes/specials/SpecialVersion.php:r87423,88118,88124,88211,88498,89099,89401,89451
Index: branches/REL1_17/phase3/resources/Resources.php
@@ -104,6 +104,7 @@
105105 'jquery.suggestions' => array(
106106 'scripts' => 'resources/jquery/jquery.suggestions.js',
107107 'styles' => 'resources/jquery/jquery.suggestions.css',
 108+ 'dependencies' => 'jquery.autoEllipsis',
108109 ),
109110 'jquery.tabIndex' => array(
110111 'scripts' => 'resources/jquery/jquery.tabIndex.js'
Property changes on: branches/REL1_17/phase3/resources/Resources.php
___________________________________________________________________
Modified: svn:mergeinfo
111112 Merged /trunk/phase3/resources/Resources.php:r87423,88118,88124,88211,88498,89099,89401,89451

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87423* (bug 28812) API's parse module documentation should no longer include secti...reedy18:14, 4 May 2011
r88118Fix Bug 28979 — “remove some CSS for abbr and acronym tags”...mah22:10, 14 May 2011
r88124Add Rotem Liss and Platonides to author list.siebrand23:11, 14 May 2011
r88211(bug 28174) Message amended so as to not explicitly refer to LTR/RTL screen l...purodha01:33, 16 May 2011
r88498Followup r88118. Fix Bug 28979 — “remove some CSS for abbr and acronym...mah22:27, 20 May 2011
r89099Fix message key for account creation by e-mail....raymond13:22, 29 May 2011
r89401(bug 29121) jquery.suggestions uses jquery.autoEllipsis but didn't have it in...catrope09:51, 3 June 2011
r89451Followup r88124: fix the most glaring bug of the weekdemon02:54, 4 June 2011
r896701.17wmf1: MFT r87423, r88118, r88124, r88211, r88498, r89099, r89401, r89451catrope18:39, 7 June 2011

Status & tagging log