r90258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90257‎ | r90258 | r90259 >
Date:04:46, 17 June 2011
Author:tstarling
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/installer (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/REL1_18/phase3/includes/libs/CSSMin.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/createAndPromote.php (modified) (history)
  • /branches/REL1_18/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)
  • /branches/REL1_18/phase3/skins/chick/main.css (modified) (history)
  • /branches/REL1_18/phase3/skins/common/shared.css (modified) (history)
  • /branches/REL1_18/phase3/skins/monobook/main.css (modified) (history)
  • /branches/REL1_18/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/maintenance/createAndPromote.php
@@ -61,7 +61,7 @@
6262
6363 # Promote user
6464 if ( $this->hasOption( 'sysop' ) ) {
65 - $user->addGroup( 'bureaucrat' );
 65+ $user->addGroup( 'sysop' );
6666 }
6767 if ( $this->hasOption( 'bureaucrat' ) ) {
6868 $user->addGroup( 'bureaucrat' );
Index: branches/REL1_18/phase3/skins/chick/main.css
@@ -146,12 +146,6 @@
147147 color: black;
148148 vertical-align: top;
149149 }
150 -abbr, acronym, .explain {
151 - border-bottom: 1px dotted black;
152 - color: black;
153 - background: none;
154 - cursor: help;
155 -}
156150 q {
157151 font-family: Times, "Times New Roman", serif;
158152 font-style: italic;
Index: branches/REL1_18/phase3/skins/monobook/main.css
@@ -199,12 +199,6 @@
200200 select {
201201 vertical-align: top;
202202 }
203 -abbr, acronym, .explain {
204 - border-bottom: 1px dotted black;
205 - color: black;
206 - background: none;
207 - cursor: help;
208 -}
209203 q {
210204 font-family: Times, "Times New Roman", serif;
211205 font-style: italic;
Index: branches/REL1_18/phase3/skins/common/shared.css
@@ -4,6 +4,12 @@
55 * another, but don't ignore the poor pre-Monobook users either.
66 */
77
 8+/* Default style for semantic tags */
 9+abbr, acronym, .explain {
 10+ border-bottom: 1px dotted black;
 11+ cursor: help;
 12+}
 13+
814 /* Colored watchlist and recent changes numbers */
915 .mw-plusminus-pos { color: #006400; } /* dark green */
1016 .mw-plusminus-neg { color: #8b0000; } /* dark red */
Index: branches/REL1_18/phase3/skins/vector/screen.css
@@ -765,16 +765,8 @@
766766 margin: .4em 0 .5em 0;
767767 line-height: 1.5em;
768768 }
769 - p img {
770 - margin: 0;
771 - }
772 -abbr,
773 -acronym,
774 -.explain {
775 - border-bottom: 1px dotted black;
776 - color: black;
777 - background: none;
778 - cursor: help;
 769+p img {
 770+ margin: 0;
779771 }
780772 q {
781773 font-family: Times, "Times New Roman", serif;
Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -250,6 +250,7 @@
251251 * (bug 28076) Thumbnail height limited to 360 pixels on Special:Listfiles
252252 * (bug 22227) Special:Listfiles no longer throws an error on bogus file entries
253253 * (bug 19408) user_properties.up_property: 32 bytes is not enough.
 254+* (bug 25262) Fix for minification of hardcoded data: URIs in CSS
254255
255256 === API changes in 1.18 ===
256257 * (bug 26339) Throw warning when truncating an overlarge API result.
Index: branches/REL1_18/phase3/includes/installer/Installer.php
@@ -1150,7 +1150,13 @@
11511151 break;
11521152 }
11531153
1154 - $text = Http::get( $url . $file, array( 'timeout' => 3 ) );
 1154+ try {
 1155+ $text = Http::get( $url . $file, array( 'timeout' => 3 ) );
 1156+ }
 1157+ catch( MWException $e ) {
 1158+ // Http::get throws with allow_url_fopen = false and no curl extension.
 1159+ $text = null;
 1160+ }
11551161 unlink( $dir . $file );
11561162
11571163 if ( $text == 'exec' ) {
Property changes on: branches/REL1_18/phase3/includes/installer
___________________________________________________________________
Modified: svn:mergeinfo
11581164 Merged /trunk/phase3/includes/installer:r87586,87840,88085,88118,88124,88492,88498
Index: branches/REL1_18/phase3/includes/libs/CSSMin.php
@@ -120,8 +120,9 @@
121121 self::URL_REGEX . '(?P<post>[^;]*)[\;]?/';
122122 $offset = 0;
123123 while ( preg_match( $pattern, $source, $match, PREG_OFFSET_CAPTURE, $offset ) ) {
124 - // Skip absolute URIs
125 - if ( preg_match( '/^https?:\/\//', $match['file'][0] ) ) {
 124+ // Skip fully-qualified URLs and data URIs
 125+ $urlScheme = parse_url( $match['file'][0], PHP_URL_SCHEME );
 126+ if ( $urlScheme ) {
126127 // Move the offset to the end of the match, leaving it alone
127128 $offset = $match[0][1] + strlen( $match[0][0] );
128129 continue;
Index: branches/REL1_18/phase3/includes/specials/SpecialVersion.php
@@ -109,6 +109,7 @@
110110 'Aryeh Gregor', 'Aaron Schulz', 'Andrew Garrett', 'Raimond Spekking',
111111 'Alexandre Emsenhuber', 'Siebrand Mazeland', 'Chad Horohoe',
112112 'Roan Kattouw', 'Trevor Parscal', 'Bryan Tong Minh', 'Sam Reed',
 113+ 'Victor Vasiliev', 'Rotem Liss', 'Platonides',
113114 wfMsg( 'version-poweredby-others' )
114115 );
115116
Property changes on: branches/REL1_18/phase3/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
116117 Merged /trunk/phase3/includes/specials:r87586,87840,88085,88118,88124,88492,88498
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
117118 Merged /trunk/phase3/includes:r87586,87840,88085,88118,88124,88492,88498
Index: branches/REL1_18/phase3/resources/mediawiki.util/mediawiki.util.js
@@ -271,17 +271,6 @@
272272 '$content' : null,
273273
274274 /**
275 - * Checks wether the current page is the wiki's main page.
276 - *
277 - * @return Boolean
278 - * @deprecated to be removed in 1.18: Use wgIsMainPage in mw.config instead.
279 - */
280 - 'isMainPage' : function() {
281 - return mw.config.get( 'wgIsMainPage' );
282 - },
283 -
284 -
285 - /**
286275 * Add a link to a portlet menu on the page, such as:
287276 *
288277 * p-cactions (Content actions), p-personal (Personal tools),
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
289278 Merged /trunk/phase3:r87586,87840,88085,88118,88124,88492,88498

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87586mw.util.isMainPage(); Was never released, removing before release since it's ...krinkle21:55, 6 May 2011
r87840* (bug 25262) Fix for minification of hardcoded data: URIs in CSS...brion20:14, 10 May 2011
r88085Fix broken --sysop flag in r87480: it was triggering the bureaucrat right ins...catrope14:20, 14 May 2011
r88118Fix Bug 28979 — “remove some CSS for abbr and acronym tags”...mah22:10, 14 May 2011
r88124Add Rotem Liss and Platonides to author list.siebrand23:11, 14 May 2011
r88492Do not block the installer (through an unhandled exception) when we can't con...platonides21:42, 20 May 2011
r88498Followup r88118. Fix Bug 28979 — “remove some CSS for abbr and acronym...mah22:27, 20 May 2011

Status & tagging log