r82486 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82485‎ | r82486 | r82487 >
Date:21:03, 19 February 2011
Author:hartman
Status:ok
Tags:
Comment:
Don't use getCheck, because the opts array is reused to generate the query for the RSS/Atom feed.
getCheck checks for presence, not for true/false, so that was why rss feeds behaved as if
deletedOnly was set.

Follow up to r65651
Fixes bug #27546
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -58,7 +58,7 @@
5959 $this->opts['contribs'] = 'newbie';
6060 }
6161
62 - $this->opts['deletedOnly'] = $wgRequest->getCheck( 'deletedOnly' );
 62+ $this->opts['deletedOnly'] = $wgRequest->getBool( 'deletedOnly' );
6363
6464 if( !strlen( $target ) ) {
6565 $wgOut->addHTML( $this->getForm() );
@@ -67,7 +67,7 @@
6868
6969 $this->opts['limit'] = $wgRequest->getInt( 'limit', $wgUser->getOption('rclimit') );
7070 $this->opts['target'] = $target;
71 - $this->opts['topOnly'] = $wgRequest->getCheck( 'topOnly' );
 71+ $this->opts['topOnly'] = $wgRequest->getBool( 'topOnly' );
7272
7373 $nt = Title::makeTitleSafe( NS_USER, $target );
7474 if( !$nt ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r825331.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...catrope20:13, 20 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65651follow-up on r65546#c6661: minor code style issue. (suggested by Nikerabbit)churchofemacs10:28, 29 April 2010

Status & tagging log