r65651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65650‎ | r65651 | r65652 >
Date:10:28, 29 April 2010
Author:churchofemacs
Status:resolved (Comments)
Tags:
Comment:
follow-up on r65546#c6661: minor code style issue. (suggested by Nikerabbit)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -34,7 +34,7 @@
3535 $this->opts['contribs'] = 'newbie';
3636 }
3737
38 - $this->opts['deletedOnly'] = ( $wgRequest->getVal( 'deletedOnly' ) == '1' );
 38+ $this->opts['deletedOnly'] = $wgRequest->getCheck( 'deletedOnly' );
3939
4040 if( !strlen( $target ) ) {
4141 $wgOut->addHTML( $this->getForm() );

Follow-up revisions

RevisionCommit summaryAuthorDate
r82486Don't use getCheck, because the opts array is reused to generate the query fo...hartman21:03, 19 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65546fixing bug 20186: allow filtering SpecialContributions for RevisionDeleted ed...churchofemacs16:35, 26 April 2010

Comments

#Comment by Platonides (talk | contribs)   00:00, 19 February 2011

Causes bug 27546

Status & tagging log