r82487 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82486‎ | r82487 | r82488 >
Date:21:16, 19 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Improve method documentation

Few bits of fixup
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Standard.php
@@ -18,9 +18,6 @@
1919 var $skinname = 'standard', $stylename = 'standard',
2020 $template = 'StandardTemplate';
2121
22 - /**
23 - *
24 - */
2522 function setupSkinUserCss( OutputPage $out ){
2623 parent::setupSkinUserCss( $out );
2724 $out->AddModuleStyles( 'skins.standard' );
Index: trunk/phase3/skins/Vector.php
@@ -61,7 +61,7 @@
6262 /* Members */
6363
6464 /**
65 - * @var Cached skin object
 65+ * @var Skin Cached skin object
6666 */
6767 var $skin;
6868
@@ -80,7 +80,7 @@
8181 $nav = $this->data['content_navigation'];
8282
8383 if ( $wgVectorUseIconWatch ) {
84 - $mode = $this->skin->mTitle->userIsWatching() ? 'unwatch' : 'watch';
 84+ $mode = $this->skin->getTitle()->userIsWatching() ? 'unwatch' : 'watch';
8585 if ( isset($nav['actions'][$mode]) ) {
8686 $nav['views'][$mode] = $nav['actions'][$mode];
8787 $nav['views'][$mode]['class'] = rtrim('icon ' . $nav['views'][$mode]['class'], ' ');
@@ -88,7 +88,8 @@
8989 unset($nav['actions'][$mode]);
9090 }
9191 }
92 -
 92+
 93+ $xmlID = '';
9394 foreach ( $nav as $section => $links ) {
9495 foreach ( $links as $key => $link ) {
9596 if ( $section == "views" && !(isset($link["primary"]) && $link["primary"]) ) {
Index: trunk/phase3/skins/MonoBook.php
@@ -52,7 +52,12 @@
5353 * @ingroup Skins
5454 */
5555 class MonoBookTemplate extends BaseTemplate {
 56+
 57+ /**
 58+ * @var Skin
 59+ */
5660 var $skin;
 61+
5762 /**
5863 * Template filter callback for MonoBook skin.
5964 * Takes an associative array of data set from a SkinTemplate-based
Index: trunk/phase3/skins/Modern.php
@@ -32,6 +32,10 @@
3333 * @ingroup Skins
3434 */
3535 class ModernTemplate extends MonoBookTemplate {
 36+
 37+ /**
 38+ * @var Skin
 39+ */
3640 var $skin;
3741 /**
3842 * Template filter callback for Modern skin.
@@ -44,7 +48,6 @@
4549 function execute() {
4650 global $wgRequest;
4751 $this->skin = $skin = $this->data['skin'];
48 - $action = $wgRequest->getText( 'action' );
4952
5053 // Suppress warnings to prevent notices about missing indexes in $this->data
5154 wfSuppressWarnings();
Index: trunk/phase3/includes/Skin.php
@@ -360,7 +360,10 @@
361361 $this->mTitle = $t;
362362 }
363363
364 - /** Get the title */
 364+ /** Get the title
 365+ *
 366+ * @return Title
 367+ */
365368 public function getTitle() {
366369 return $this->mTitle;
367370 }

Sign-offs

UserFlagDate
Hasharinspected07:20, 22 February 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r99353Fix bug 31436....hartman15:35, 9 October 2011

Status & tagging log