r82131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82130‎ | r82131 | r82132 >
Date:19:55, 14 February 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Just telling users that a revision status has changed without giving them a link is a bit useless!
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -162,8 +162,10 @@
163163 'codereview-email-body3' => 'User "$1" changed the status of $2.
164164
165165 Old Status: $3
166 -New Status: $4',
 166+New Status: $4
167167
 168+Full URL: $5',
 169+
168170 'codereview-email-subj4' => '[$1 $2]: New comment added, and revision status changed',
169171 'codereview-email-body4' => 'User "$1" changed the status of $2.
170172
Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
@@ -117,18 +117,18 @@
118118 $dbw->commit();
119119
120120 if ( $statusChanged || $commentAdded ) {
 121+ $url = $this->mRev->getFullUrl( $commentId );
121122 if ( $statusChanged && $commentAdded ) {
122 - $url = $this->mRev->getFullUrl( $commentId );
123123 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj4', 'codereview-email-body4',
124 - $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->getOldStatus(), $this->mRev->getStatus(),
125 - $url, $this->text
 124+ $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->getOldStatus(),
 125+ $this->mRev->getStatus(), $url, $this->text
126126 );
127127 } else if ( $statusChanged ) {
128128 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj3', 'codereview-email-body3',
129 - $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->getOldStatus(), $this->mRev->getStatus()
 129+ $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->getOldStatus(),
 130+ $this->mRev->getStatus(), $url
130131 );
131132 } else if ( $commentAdded ) {
132 - $url = $this->mRev->getFullUrl( $commentId );
133133 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj', 'codereview-email-body',
134134 $wgUser->getName(), $url, $this->mRev->getIdStringUnique(), $this->text
135135 );

Sign-offs

UserFlagDate
Krinkleinspected21:36, 14 February 2011 (struck 21:36, 14 February 2011)
Krinkleinspected21:37, 14 February 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r821511.17wmf1: MFT r78964, r79086, r79087, r79091, r82004, r82025, r82048, r82070,...catrope22:55, 14 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Comments

#Comment by Reedy (talk | contribs)   21:34, 14 February 2011

Tagging due to the message for just status change is a bit useless.

Tweaking message and parameters in this commit. Please merge out for usefulness

Status & tagging log