r82132 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82131‎ | r82132 | r82133 >
Date:19:58, 14 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup hard coding usage of $wgUser->getName() in CodeRevision::emailNotifyUsersOfChanges

Minor documentation
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -575,14 +575,14 @@
576576 }
577577
578578 /**
579 - * @param $subject
580 - * @param $body
 579+ * @param $subject String
 580+ * @param $body String
581581 * @return void
582582 */
583583 public function emailNotifyUsersOfChanges( $subject, $body ) {
584584 // Give email notices to committer and commenters
585585 global $wgCodeReviewENotif, $wgEnableEmail, $wgCodeReviewCommentWatcherEmail,
586 - $wgCodeReviewCommentWatcherName, $wgUser;
 586+ $wgCodeReviewCommentWatcherName;
587587 if ( !$wgCodeReviewENotif || !$wgEnableEmail ) {
588588 return;
589589 }
@@ -613,7 +613,7 @@
614614 $lang = array( 'language' => $user->getOption( 'language' ) );
615615
616616 $localSubject = wfMsgExt( $subject, $lang, $this->repo->getName(), $this->getIdString() );
617 - $localBody = call_user_func_array( 'wfMsgExt', array_merge( array( $body, $lang, $wgUser->getName() ), $args ) );
 617+ $localBody = call_user_func_array( 'wfMsgExt', array_merge( array( $body, $lang ), $args ) );
618618
619619 $user->sendMail( $localSubject, $localBody );
620620 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r821331.17wmf1: MFT r82132. Merging this first because the same change is present a...catrope20:09, 14 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Status & tagging log