r81713 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81712‎ | r81713 | r81714 >
Date:10:46, 8 February 2011
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Merge r81712 from 1.17wmf1: fix ReaderFeedback extension, was adding a <script> to the <head> in an ugly way, causing JS errors with ResourceLoader
Modified paths:
  • /trunk/extensions/ReaderFeedback/ReaderFeedback.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ReaderFeedback/ReaderFeedback.hooks.php
——@@ -24,8 +24,7 @@
2525 // Add CSS
2626 $wgOut->addExtensionStyle( $encCssFile );
2727 // Add JS
28 - $head = "<script type=\"$wgJsMimeType\" src=\"$encJsFile\"></script>\n";
29 - $wgOut->addHeadItem( 'ReaderFeedback', $head );
 28+ $wgOut->addScriptFile( "$stylepath/readerfeedback.js?$wgFeedbackStyleVersion" );
3029
3130 return true;
3231 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r81734Merge r81733 from 1.17wmf1: rudimetary fixup of ReaderFeedback JS/CSS loading...catrope12:44, 8 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r817121.17wmf1: Fix ReaderFeedback, which was adding a <script> to the <head> in an...catrope10:43, 8 February 2011

Comments

#Comment by Bryan (talk | contribs)   21:01, 10 February 2011

Capitalization of $stylePath.

Status & tagging log