r81657 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81656‎ | r81657 | r81658 >
Date:23:21, 7 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Per fixme on r77597, change to $this->addQuotes() instead of hardcoded quote type
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
——@@ -1625,7 +1625,7 @@
16261626 if ( !$alias || $alias == $name ) {
16271627 return $this->tableName( $name );
16281628 } else {
1629 - return $this->tableName( $name ) . ' `' . $alias . '`';
 1629+ return $this->tableName( $name ) . $this->addQuotes( $alias );
16301630 }
16311631 }
16321632

Follow-up revisions

RevisionCommit summaryAuthorDate
r816981.17wmf1: MFT r80837, r81612, r81615, r81657, r81674, r81689catrope08:21, 8 February 2011
r81755Followup to r81657, you do need a space between the table name and the aliasoverlordq15:34, 8 February 2011
r81833Fixup fixme on r81030, which should actually have been a fixme on r81657reedy18:57, 9 February 2011
r81834MFT r81657, and fixing revision r81833reedy19:02, 9 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77597Per Roans request, Merge in r65475 (Database.php only) from querypage-work2 b...reedy19:39, 2 December 2010

Status & tagging log