r81755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81754‎ | r81755 | r81756 >
Date:15:34, 8 February 2011
Author:overlordq
Status:ok
Tags:
Comment:
Followup to r81657, you do need a space between the table name and the alias
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
——@@ -1625,7 +1625,7 @@
16261626 if ( !$alias || $alias == $name ) {
16271627 return $this->tableName( $name );
16281628 } else {
1629 - return $this->tableName( $name ) . $this->addQuotes( $alias );
 1629+ return $this->tableName( $name ) . ' ' . $this->addQuotes( $alias );
16301630 }
16311631 }
16321632

Follow-up revisions

RevisionCommit summaryAuthorDate
r85081MFT last round of db and installer changes: r81755, r82596, r85021, r85047, r...demon19:33, 31 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81657Per fixme on r77597, change to $this->addQuotes() instead of hardcoded quote ...reedy23:21, 7 February 2011

Status & tagging log