r81615 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81614‎ | r81615 | r81616 >
Date:22:53, 6 February 2011
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Follow-up r81612, disable $wgAllowAsyncCopyUploads
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadFromUrl.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadFromUrl.php
@@ -45,6 +45,9 @@
4646
4747 $this->mUrl = $url;
4848 $this->mAsync = $wgAllowAsyncCopyUploads ? $async : false;
 49+ if ( $async ) {
 50+ throw new MWException( 'Asynchronous copy uploads are no longer possible as of r81612.' );
 51+ }
4952
5053 $tempPath = $this->mAsync ? null : $this->makeTemporaryFile();
5154 # File size and removeTempFile will be filled in later
Index: trunk/phase3/includes/DefaultSettings.php
@@ -434,7 +434,7 @@
435435 $wgAllowCopyUploads = false;
436436 /**
437437 * Allow asynchronous copy uploads.
438 - * This feature is experimental.
 438+ * This feature is experimental is broken as of r81612.
439439 */
440440 $wgAllowAsyncCopyUploads = false;
441441

Follow-up revisions

RevisionCommit summaryAuthorDate
r816981.17wmf1: MFT r80837, r81612, r81615, r81657, r81674, r81689catrope08:21, 8 February 2011
r89036Fix type, follow-up r81615krinkle14:51, 28 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81612Per CR r66438 and IRC, revert User::leaveNewMessage for now. Copied the funct...btongminh22:44, 6 February 2011

Comments

#Comment by Nikerabbit (talk | contribs)   15:46, 7 February 2011

I don't understand how r81612 is related to this.

#Comment by Bryan (talk | contribs)   15:54, 7 February 2011

Because it uses User::leaveNewMessage(), which was taken out at the rev.

#Comment by Nikerabbit (talk | contribs)   15:55, 7 February 2011

Ok, it was not obvious and could have been stated somewhere.

#Comment by RobLa-WMF (talk | contribs)   16:54, 7 February 2011

I'm assuming since this is a follow-up to r81612, this should be tagged for 1.17 as well.

Status & tagging log