r81674 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81673‎ | r81674 | r81675 >
Date:01:06, 8 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup fixme set by me on r71627

Move initial definition of $opening outside loop, so it's seen to be existant
Modified paths:
  • /trunk/extensions/DoubleWiki/DoubleWiki_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DoubleWiki/DoubleWiki_body.php
@@ -248,6 +248,8 @@
249249 * The first and last slices are compensated.
250250 */
251251 $stack = array();
 252+ $opening = '';
 253+
252254 for( $i=0 ; $i < $n ; $i++) {
253255 $m = array();
254256 preg_match_all( $this->tags, $left_slices[$i], $m, PREG_SET_ORDER);
@@ -263,7 +265,6 @@
264266 }
265267 }
266268 if( $i==0 ) {
267 - $opening = '';
268269 $closure = '';
269270 for( $k=0; $k < $counter ; $k++ ) {
270271 $opening .= "<".$stack[$k][1].">";

Follow-up revisions

RevisionCommit summaryAuthorDate
r816981.17wmf1: MFT r80837, r81612, r81615, r81657, r81674, r81689catrope08:21, 8 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71627Major refactoring : ...thomasv15:17, 25 August 2010

Status & tagging log