r81689 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81688‎ | r81689 | r81690 >
Date:05:33, 8 February 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Fix bug from r73645: setMsgBlobMtime() requires its timestamp parameter to be a UNIX timestamp, which $row->mr_timestamp isn't. This was causing incorrect versions in the client-side module list, resulting in requests for URLs with "version=NaNNaNNaNTNaNNaNNaNZ", which Michael has been occasionally complaining about.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
——@@ -95,7 +95,8 @@
9696 ), __METHOD__
9797 );
9898 foreach ( $res as $row ) {
99 - $this->getModule( $row->mr_resource )->setMsgBlobMtime( $lang, $row->mr_timestamp );
 99+ $this->getModule( $row->mr_resource )->setMsgBlobMtime( $lang,
 100+ wfTimestamp( TS_UNIX, $row->mr_timestamp ) );
100101 unset( $modulesWithoutMessages[$row->mr_resource] );
101102 }
102103 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r81690MFT r81689: version=NaNNaNNaNTNaNNaNNaNZtstarling05:35, 8 February 2011
r816981.17wmf1: MFT r80837, r81612, r81615, r81657, r81674, r81689catrope08:21, 8 February 2011
r96557MFT r80167, r81689, r87498, r89253reedy12:38, 8 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73645Improved the performance of ResourceLoader by pre-loading module information ...tparscal21:23, 23 September 2010

Comments

#Comment by Catrope (talk | contribs)   07:07, 8 February 2011

Thanks. Niklas had been complaining about these NaNs as well, and I thought I'd found the cause. NaN URLs generally shouldn't happen since we format the timestamp to UNIX before outputting it to JS.

Status & tagging log