r81833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81832‎ | r81833 | r81834 >
Date:18:57, 9 February 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup fixme on r81030, which should actually have been a fixme on r81657
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
——@@ -1625,7 +1625,7 @@
16261626 if ( !$alias || $alias == $name ) {
16271627 return $this->tableName( $name );
16281628 } else {
1629 - return $this->tableName( $name ) . ' ' . $this->addQuotes( $alias );
 1629+ return $this->tableName( $name ) . ' ' . $this->addIdentifierQuotes( $alias );
16301630 }
16311631 }
16321632

Follow-up revisions

RevisionCommit summaryAuthorDate
r81834MFT r81657, and fixing revision r81833reedy19:02, 9 February 2011
r818351.17wm1: MFT r81833reedy19:10, 9 February 2011
r88396MFT r81833demon22:28, 18 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81030Reapplying r70018 in a cleaner wayreedy16:28, 26 January 2011
r81657Per fixme on r77597, change to $this->addQuotes() instead of hardcoded quote ...reedy23:21, 7 February 2011

Status & tagging log