r78896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78895‎ | r78896 | r78897 >
Date:17:47, 23 December 2010
Author:reedy
Status:deferred
Tags:
Comment:
Kill all wfLoadExtensionMessages('OpenStackManager');

1.15 back compat isn't needed
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaHost.php (modified) (history)
  • /trunk/extensions/OpenStackManager/SpecialNovaDomain.php (modified) (history)
  • /trunk/extensions/OpenStackManager/SpecialNovaInstance.php (modified) (history)
  • /trunk/extensions/OpenStackManager/SpecialNovaKey.php (modified) (history)
  • /trunk/extensions/OpenStackManager/SpecialNovaProject.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaHost.php
@@ -141,6 +141,13 @@
142142 }
143143 }
144144
 145+ /**
 146+ * @static
 147+ * @param $hostname
 148+ * @param $ip
 149+ * @param $domain OpenStackNovaDomain
 150+ * @return bool
 151+ */
145152 static function addHost( $hostname, $ip, $domain ) {
146153 global $wgAuth;
147154 global $wgOpenStackManagerLDAPUser, $wgOpenStackManagerLDAPUserPassword;
Index: trunk/extensions/OpenStackManager/SpecialNovaInstance.php
@@ -12,7 +12,6 @@
1313 global $wgRequest, $wgUser;
1414 global $wgOpenStackManagerNovaAdminKeys;
1515
16 - wfLoadExtensionMessages('OpenStackManager');
1716 if ( ! $wgUser->isLoggedIn() ) {
1817 $this->notLoggedIn();
1918 return true;
Index: trunk/extensions/OpenStackManager/SpecialNovaProject.php
@@ -30,8 +30,6 @@
3131 function execute( $par ) {
3232 global $wgRequest, $wgUser;
3333
34 - wfLoadExtensionMessages('OpenStackManager');
35 -
3634 #if ( ! $wgUser->isAllowed( 'manageproject' ) ) {
3735 # return false;
3836 #}
Index: trunk/extensions/OpenStackManager/SpecialNovaDomain.php
@@ -19,8 +19,6 @@
2020 function execute( $par ) {
2121 global $wgRequest, $wgUser;
2222
23 - wfLoadExtensionMessages('OpenStackManager');
24 -
2523 #if ( ! $wgUser->isAllowed( 'manageproject' ) ) {
2624 # return false;
2725 #}
Index: trunk/extensions/OpenStackManager/SpecialNovaKey.php
@@ -14,8 +14,6 @@
1515 function execute( $par ) {
1616 global $wgRequest, $wgUser;
1717
18 - wfLoadExtensionMessages('OpenStackManager');
19 -
2018 if ( ! $wgUser->isLoggedIn() ) {
2119 $this->notLoggedIn();
2220 return true;

Status & tagging log