r26135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26134‎ | r26135 | r26136 >
Date:21:15, 25 September 2007
Author:david
Status:old
Tags:
Comment:
Merged revisions 26012-26133 via svnmerge from
svn+ssh://david@svn.wikimedia.org/svnroot/mediawiki/trunk/phase3

........
r26016 | siebrand | 2007-09-21 14:32:23 -0700 (Fri, 21 Sep 2007) | 1 line

Update for Maylay (ms) messages (bugzilla 11421)
........
r26017 | siebrand | 2007-09-21 16:12:15 -0700 (Fri, 21 Sep 2007) | 1 line

Adding namespace aliases for ms for backward compatibility after changing namespace names in previous commit.
........
r26018 | siebrand | 2007-09-21 16:15:52 -0700 (Fri, 21 Sep 2007) | 1 line

Remove double entry in namespace aliases
........
r26019 | rotem | 2007-09-21 18:59:31 -0700 (Fri, 21 Sep 2007) | 1 line

Update.
........
r26024 | rotem | 2007-09-22 20:52:39 -0700 (Sat, 22 Sep 2007) | 1 line

Fix.
........
r26025 | siebrand | 2007-09-23 03:20:16 -0700 (Sun, 23 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* am, ast, bcl, bn, bpy, dsb, hsb, it, li, no, sah, sei (new), tet.
........
r26028 | wegge | 2007-09-23 03:56:53 -0700 (Sun, 23 Sep 2007) | 1 line

Updated translations for da
........
r26034 | siebrand | 2007-09-23 10:58:49 -0700 (Sun, 23 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* am, ar, bcl, cy, hsb, la, nl, sei, tet.
........
r26035 | nikerabbit | 2007-09-23 11:25:26 -0700 (Sun, 23 Sep 2007) | 2 lines

* Some special page aliases for (tet)
........
r26037 | siebrand | 2007-09-23 11:42:44 -0700 (Sun, 23 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* la (also resolved encoding issue).
........
r26038 | siebrand | 2007-09-23 11:45:52 -0700 (Sun, 23 Sep 2007) | 1 line

Fix typo (thanks to Bryan)
........
r26039 | siebrand | 2007-09-23 12:28:59 -0700 (Sun, 23 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* la.
........
r26040 | greg | 2007-09-23 12:54:56 -0700 (Sun, 23 Sep 2007) | 2 lines

Fix bug 11292, unserialize errors with Postgres, by changing from array to object when slinging around blobs.
........
r26041 | nikerabbit | 2007-09-23 12:59:59 -0700 (Sun, 23 Sep 2007) | 2 lines

* Fix to special page aliases
........
r26042 | greg | 2007-09-23 13:47:17 -0700 (Sun, 23 Sep 2007) | 2 lines

(Bug 11363). Change image and filearchive to bytea from text, to match oldimage.
........
r26043 | greg | 2007-09-23 15:23:01 -0700 (Sun, 23 Sep 2007) | 5 lines

Make CONCAT calls database portable, change IF() to standard CASE-WHEN calls.
Postgres: replace CHAR(64) with TEXT for fa_storage_key of filearchive
Postgres: Add hasConstraint to allow replacing of oldimage fk constraint
Postgres: make oldimage cascade delete on image deletion
........
r26046 | aaron | 2007-09-23 17:23:14 -0700 (Sun, 23 Sep 2007) | 1 line

*Kill references to non-existent php files (bug 11433)
........
r26047 | aaron | 2007-09-23 17:28:13 -0700 (Sun, 23 Sep 2007) | 1 line

*Typo fix (bug 11434)
........
r26048 | aaron | 2007-09-23 17:47:05 -0700 (Sun, 23 Sep 2007) | 2 lines

*Actually delete the files too (bug 8250)
*Make notices more specific
........
r26058 | simetrical | 2007-09-23 21:43:23 -0700 (Sun, 23 Sep 2007) | 1 line

(bug 5412) Add feed links for the site (i.e., Recentchanges) to all pages.
........
r26059 | simetrical | 2007-09-23 21:56:37 -0700 (Sun, 23 Sep 2007) | 1 line

"' onload='send_me_your_credit_card_info()" would be an interesting page name, don't you think?
........
r26060 | rotem | 2007-09-23 22:06:17 -0700 (Sun, 23 Sep 2007) | 1 line

Update.
........
r26065 | raymond | 2007-09-24 03:56:13 -0700 (Mon, 24 Sep 2007) | 2 lines

* (bug 11429) Update French translations
Patch by Bertrand GRONDIN
........
r26070 | simetrical | 2007-09-24 05:54:00 -0700 (Mon, 24 Sep 2007) | 1 line

Actually, Sanitizer::encodeAttribute() was broken, so my last fix didn't actually work, there was still HTML injection. Fixed it so it encodes single quotes too. The only other things in core that used it (or its friend safeEncodeAttribute) appear to be utility functions in Xml and Sanitizer::fixTagAttributes, all of which use double quotes. However, it's possible that the SemanticForms extension may be affected -- I didn't look closely, but it seems to safely use double-quotes.
........
r26071 | raymond | 2007-09-24 06:21:35 -0700 (Mon, 24 Sep 2007) | 2 lines

* (bug 11035) Add descriptive <title> to Special:Search
* Proper header for direct call of Special:Search
........
r26073 | nikerabbit | 2007-09-24 06:46:14 -0700 (Mon, 24 Sep 2007) | 3 lines

Committing a version which at least shows the text preview properly
* (bug 11438) Live Preview chops returned text
........
r26077 | brion | 2007-09-24 11:25:56 -0700 (Mon, 24 Sep 2007) | 5 lines

Clean up r26058, r26059 a bit...
* We've got these nice functions to do escaping of XML for us, use them. :)
* Swapped order so per-page feeds (history, newpages, etc) show up first
I'm still not too thrilled with the message texts on the titles.
........
r26078 | brion | 2007-09-24 11:30:42 -0700 (Mon, 24 Sep 2007) | 3 lines

Clean up after r26070:
* Fix parser test cases whose results are altered by the extra escaping
........
r26079 | brion | 2007-09-24 11:40:36 -0700 (Mon, 24 Sep 2007) | 2 lines

Revert r26071 -- clearly not tested at all; title text is double-escaped.
........
r26080 | raymond | 2007-09-24 11:48:22 -0700 (Mon, 24 Sep 2007) | 1 line

* Update German
........
r26081 | huji | 2007-09-24 11:59:24 -0700 (Mon, 24 Sep 2007) | 1 line

Updating persian translations
........
r26084 | raymond | 2007-09-24 12:48:11 -0700 (Mon, 24 Sep 2007) | 3 lines

* (bug 11035) Add descriptive <title> to Special:Search
* Proper header for direct call of Special:Search
(the former r26071 was tested but with German interface/quotation marks only, my fault :-( )
........
r26085 | greg | 2007-09-24 13:09:02 -0700 (Mon, 24 Sep 2007) | 2 lines

Add column type brains, map out all non-standard stuff
........
r26086 | greg | 2007-09-24 13:10:00 -0700 (Mon, 24 Sep 2007) | 2 lines

Major cleanup of schema, based on new compare_schemas.pl functionality.
........
r26087 | siebrand | 2007-09-24 13:13:14 -0700 (Mon, 24 Sep 2007) | 1 line

Revert namespace names, magic words and special page aliases from r26034. Was causing problems in ar.wp.
........
r26089 | brion | 2007-09-24 14:11:43 -0700 (Mon, 24 Sep 2007) | 2 lines

Revert r26084; as mentioned on list this still is a bit odd, with duplication between title and subtitle texts
........
r26090 | raymond | 2007-09-24 14:27:15 -0700 (Mon, 24 Sep 2007) | 4 lines

* (bug 8376) Special:Newpages accepts namespace in subpage form (again?)
* Removing some code which seems useless/outdated, parameters &limit=, &offset=, &username=... works furthermore
* Make input form nicer for RTL wikis
* Found and fixed another bug: namespace selection was lost after submit
........
r26095 | siebrand | 2007-09-24 16:36:53 -0700 (Mon, 24 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* am, bcl, cs, fi, grc, is, ja, ko, la, nds, pt, tet.
........
r26096 | siebrand | 2007-09-24 16:43:23 -0700 (Mon, 24 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* dsb
........
r26100 | rotem | 2007-09-24 17:38:15 -0700 (Mon, 24 Sep 2007) | 1 line

Fix.
........
r26104 | rotem | 2007-09-24 21:25:48 -0700 (Mon, 24 Sep 2007) | 1 line

Show the right message on account creation when the user is blocked.
........
r26109 | raymond | 2007-09-25 07:01:57 -0700 (Tue, 25 Sep 2007) | 2 lines

* (bug 11421) fix broken UTF-8 characters
* Untranslated, optional and to-be-ignored messages removed
........
r26110 | brion | 2007-09-25 07:14:49 -0700 (Tue, 25 Sep 2007) | 2 lines

Revert r26090 -- breaks parameters for Special:Newpages with no explanation other than a claim that they're unused o_O
........
r26112 | raymond | 2007-09-25 07:29:41 -0700 (Tue, 25 Sep 2007) | 1 line

two more encoding fixes
........
r26116 | brion | 2007-09-25 08:08:50 -0700 (Tue, 25 Sep 2007) | 3 lines

* (bug 11450) Fix creation of objectcache table on upgrade
patch-objectcache.sql had an extra 'binary' specifier which wasn't needed and causes the table creation to fail. Whoops! :)
........
r26122 | raymond | 2007-09-25 10:02:39 -0700 (Tue, 25 Sep 2007) | 1 line

Remove wrong magic word translation
........
r26125 | catrope | 2007-09-25 11:36:25 -0700 (Tue, 25 Sep 2007) | 3 lines

API: (bug 11405) Expand templates implementation in the API
Modified patch by Bryan Tongh Minh
........
r26129 | siebrand | 2007-09-25 12:23:15 -0700 (Tue, 25 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* am, bcl, bn, bpy, cs, csb, dsb, ee (new), es, gan (new), grc, is, ja, la, sei.
........
r26130 | siebrand | 2007-09-25 12:27:49 -0700 (Tue, 25 Sep 2007) | 2 lines

Localisation updates from Betawiki.
* dsb (fix accidental inclusion of English messages), fi.
........
r26132 | nikerabbit | 2007-09-25 13:11:58 -0700 (Tue, 25 Sep 2007) | 2 lines

* Hmm, syntax terrors
........
Modified paths:
  • /branches/liquidthreads (modified) (history)
  • /branches/liquidthreads/RELEASE-NOTES (modified) (history)
  • /branches/liquidthreads/extensions/LqtModel.php (modified) (history)
  • /branches/liquidthreads/includes/AutoLoader.php (modified) (history)
  • /branches/liquidthreads/includes/Database.php (modified) (history)
  • /branches/liquidthreads/includes/DatabasePostgres.php (modified) (history)
  • /branches/liquidthreads/includes/EditPage.php (modified) (history)
  • /branches/liquidthreads/includes/FileStore.php (modified) (history)
  • /branches/liquidthreads/includes/OutputPage.php (modified) (history)
  • /branches/liquidthreads/includes/Sanitizer.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialRecentchanges.php (modified) (history)
  • /branches/liquidthreads/includes/SpecialUserlogin.php (modified) (history)
  • /branches/liquidthreads/includes/api/ApiQueryRevisions.php (modified) (history)
  • /branches/liquidthreads/includes/filerepo/LocalFile.php (modified) (history)
  • /branches/liquidthreads/languages/Names.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesAm.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesAst.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBcl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesBpy.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCsb.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesCy.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesDsb.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEe.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesEe.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesEn.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesEs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFi.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesFr.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesGan.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesGan.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesGrc.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHe.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesHsb.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesIs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesIt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesJa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesKo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesLa.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesLi.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesMs.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNds.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNl.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesNo.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesPt.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSah.php (modified) (history)
  • /branches/liquidthreads/languages/messages/MessagesSei.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesSei.php (added) (history)
  • /branches/liquidthreads/languages/messages/MessagesTet.php (modified) (history)
  • /branches/liquidthreads/maintenance/archives/patch-objectcache.sql (modified) (history)
  • /branches/liquidthreads/maintenance/deleteBatch.php (modified) (history)
  • /branches/liquidthreads/maintenance/language/messages.inc (modified) (history)
  • /branches/liquidthreads/maintenance/parserTests.txt (modified) (history)
  • /branches/liquidthreads/maintenance/postgres/compare_schemas.pl (modified) (history)
  • /branches/liquidthreads/maintenance/postgres/tables.sql (modified) (history)
  • /branches/liquidthreads/maintenance/updaters.inc (modified) (history)
  • /branches/liquidthreads/skins/common/preview.js (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r38440Another shot at bug 11035, added descriptive HTML title in standard page format.rainman15:00, 2 August 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r26016Update for Maylay (ms) messages (bugzilla 11421)siebrand21:32, 21 September 2007
r26017Adding namespace aliases for ms for backward compatibility after changing nam...siebrand23:12, 21 September 2007
r26018Remove double entry in namespace aliasessiebrand23:15, 21 September 2007
r26019Update.rotem01:59, 22 September 2007
r26024Fix.rotem03:52, 23 September 2007
r26025Localisation updates from Betawiki....siebrand10:20, 23 September 2007
r26028Updated translations for dawegge10:56, 23 September 2007
r26034Localisation updates from Betawiki....siebrand17:58, 23 September 2007
r26035* Some special page aliases for (tet)nikerabbit18:25, 23 September 2007
r26037Localisation updates from Betawiki....siebrand18:42, 23 September 2007
r26038Fix typo (thanks to Bryan)siebrand18:45, 23 September 2007
r26039Localisation updates from Betawiki....siebrand19:28, 23 September 2007
r26040Fix bug 11292, unserialize errors with Postgres, by changing from array to ob...greg19:54, 23 September 2007
r26041* Fix to special page aliasesnikerabbit19:59, 23 September 2007
r26042(Bug 11363). Change image and filearchive to bytea from text, to match oldimage.greg20:47, 23 September 2007
r26043Make CONCAT calls database portable, change IF() to standard CASE-WHEN calls....greg22:23, 23 September 2007
r26046*Kill references to non-existent php files (bug 11433)aaron00:23, 24 September 2007
r26047*Typo fix (bug 11434)aaron00:28, 24 September 2007
r26048*Actually delete the files too (bug 8250)...aaron00:47, 24 September 2007
r26058(bug 5412) Add feed links for the site (i.e., Recentchanges) to all pages.simetrical04:43, 24 September 2007
r26059"' onload='send_me_your_credit_card_info()" would be an interesting page name...simetrical04:56, 24 September 2007
r26060Update.rotem05:06, 24 September 2007
r26065* (bug 11429) Update French translations...raymond10:56, 24 September 2007
r26070Actually, Sanitizer::encodeAttribute() was broken, so my last fix didn't actu...simetrical12:54, 24 September 2007
r26071* (bug 11035) Add descriptive <title> to Special:Search...raymond13:21, 24 September 2007
r26073Committing a version which at least shows the text preview properly...nikerabbit13:46, 24 September 2007
r26077Clean up r26058, r26059 a bit...brion18:25, 24 September 2007
r26078Clean up after r26070:...brion18:30, 24 September 2007
r26079Revert r26071 -- clearly not tested at all; title text is double-escaped.brion18:40, 24 September 2007
r26080* Update Germanraymond18:48, 24 September 2007
r26081Updating persian translationshuji18:59, 24 September 2007
r26084* (bug 11035) Add descriptive <title> to Special:Search...raymond19:48, 24 September 2007
r26085Add column type brains, map out all non-standard stuffgreg20:09, 24 September 2007
r26086Major cleanup of schema, based on new compare_schemas.pl functionality.greg20:10, 24 September 2007
r26087Revert namespace names, magic words and special page aliases from r26034. Was...siebrand20:13, 24 September 2007
r26089Revert r26084; as mentioned on list this still is a bit odd, with duplication...brion21:11, 24 September 2007
r26090* (bug 8376) Special:Newpages accepts namespace in subpage form (again?)...raymond21:27, 24 September 2007
r26095Localisation updates from Betawiki....siebrand23:36, 24 September 2007
r26096Localisation updates from Betawiki....siebrand23:43, 24 September 2007
r26100Fix.rotem00:38, 25 September 2007
r26104Show the right message on account creation when the user is blocked.rotem04:25, 25 September 2007
r26109* (bug 11421) fix broken UTF-8 characters...raymond14:01, 25 September 2007
r26110Revert r26090 -- breaks parameters for Special:Newpages with no explanation o...brion14:14, 25 September 2007
r26112two more encoding fixesraymond14:29, 25 September 2007
r26116* (bug 11450) Fix creation of objectcache table on upgrade...brion15:08, 25 September 2007
r26117Merge from trunk:...brion15:10, 25 September 2007
r26122Remove wrong magic word translationraymond17:02, 25 September 2007
r26125API: (bug 11405) Expand templates implementation in the API...catrope18:36, 25 September 2007
r26129Localisation updates from Betawiki....siebrand19:23, 25 September 2007
r26130Localisation updates from Betawiki....siebrand19:27, 25 September 2007
r26132* Hmm, syntax terrorsnikerabbit20:11, 25 September 2007

Status & tagging log