r38440 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r38439‎ | r38440 | r38441 >
Date:15:00, 2 August 2008
Author:rainman
Status:old
Tags:
Comment:
Another shot at bug 11035, added descriptive HTML title in standard page format.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -692,6 +692,7 @@
693693 ),
694694 'search' => array(
695695 'searchresults',
 696+ 'searchresults-title',
696697 'searchresulttext',
697698 'searchsubtitle',
698699 'searchsubtitleinvalid',
Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -277,8 +277,10 @@
278278 */
279279 function setupPage( $term ) {
280280 global $wgOut;
281 - if( !empty( $term ) )
282 - $wgOut->setPageTitle( wfMsg( 'searchresults' ) );
 281+ if( !empty( $term ) ){
 282+ $wgOut->setPageTitle( wfMsg( 'searchresults') );
 283+ $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsg( 'searchresults-title', $term) ) );
 284+ }
283285 $subtitlemsg = ( Title::newFromText( $term ) ? 'searchsubtitle' : 'searchsubtitleinvalid' );
284286 $wgOut->setSubtitle( $wgOut->parse( wfMsg( $subtitlemsg, wfEscapeWikiText($term) ) ) );
285287 $wgOut->setArticleRelated( false );
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1327,6 +1327,7 @@
13281328
13291329 # Search results
13301330 'searchresults' => 'Search results',
 1331+'searchresults-title' => 'Search results for $1',
13311332 'searchresulttext' => 'For more information about searching {{SITENAME}}, see [[{{MediaWiki:Helppage}}|{{int:help}}]].',
13321333 'searchsubtitle' => 'You searched for \'\'\'[[:$1]]\'\'\' ([[Special:Prefixindex/$1|all pages starting with "$1"]] | [[Special:Whatlinkshere/$1|all pages that link to "$1"]])',
13331334 'searchsubtitleinvalid' => "You searched for '''$1'''",
Index: trunk/phase3/RELEASE-NOTES
@@ -55,6 +55,7 @@
5656 * Not setting various parameters in Foreign Repos now fails more gracefully
5757 * (bug 2333) Redirects are properly rendered when previewing an edit.
5858 * (bug 14972) Use localized alias of Special:Search on all search forms
 59+* (bug 11035) Special:Search should have descriptive <title>
5960
6061 === API changes in 1.14 ===
6162

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r26071* (bug 11035) Add descriptive <title> to Special:Search...raymond13:21, 24 September 2007
r26084* (bug 11035) Add descriptive <title> to Special:Search...raymond19:48, 24 September 2007
r26135Merged revisions 26012-26133 via svnmerge from...david21:15, 25 September 2007

Status & tagging log