r106866 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106865‎ | r106866 | r106867 >
Date:21:27, 20 December 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r106849, using FormatJson::encode instead for backwards compat
Modified paths:
  • /trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php
——@@ -186,7 +186,7 @@
187187 }
188188
189189 // Build campaign list for bannerstats.js
190 - $campaignList = json_encode( $campaigns );
 190+ $campaignList = FormatJson::encode( $campaigns );
191191 $js = "wgCentralNoticeAllocationCampaigns = $campaignList;";
192192 $htmlOut .= Html::inlineScript( $js );
193193

Follow-up revisions

RevisionCommit summaryAuthorDate
r107015MFT r103297, r104003, r104210, r104999, r105015, r105740, r105800, r106166, r...awjrichards23:56, 21 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106849fixing double-quoting, using json_encode for the campaign list, disabling ret...kaldari20:11, 20 December 2011

Status & tagging log