r102198 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102197‎ | r102198 | r102199 >
Date:21:31, 6 November 2011
Author:mah
Status:ok
Tags:
Comment:
re r102027: split up long lines
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -69,7 +69,8 @@
7070 if ( $continue ) {
7171 // Fake submit button for enter keypress (bug 26267)
7272 $s .= Xml::submitButton( wfMsg( "config-$continue" ),
73 - array( 'name' => "enter-$continue", 'style' => 'visibility:hidden;overflow:hidden;width:1px;margin:0' ) ) . "\n";
 73+ array( 'name' => "enter-$continue", 'style' =>
 74+ 'visibility:hidden;overflow:hidden;width:1px;margin:0' ) ) . "\n";
7475 }
7576
7677 if ( $back ) {
@@ -133,9 +134,11 @@
134135 */
135136 protected function startLiveBox() {
136137 $this->addHTML(
137 - '<div id="config-spinner" style="display:none;"><img src="../skins/common/images/ajax-loader.gif" /></div>' .
 138+ '<div id="config-spinner" style="display:none;">' .
 139+ '<img src="../skins/common/images/ajax-loader.gif" /></div>' .
138140 '<script>jQuery( "#config-spinner" ).show();</script>' .
139 - '<div id="config-live-log"><textarea name="LiveLog" rows="10" cols="30" readonly="readonly">'
 141+ '<div id="config-live-log">' .
 142+ '<textarea name="LiveLog" rows="10" cols="30" readonly="readonly">'
140143 );
141144 $this->parent->output->flush();
142145 }
@@ -190,7 +193,8 @@
191194 } elseif ( $this->parent->showSessionWarning ) {
192195 # The user was knocked back from another page to the start
193196 # This probably indicates a session expiry
194 - $this->parent->showError( 'config-session-expired', $wgLang->formatTimePeriod( $lifetime ) );
 197+ $this->parent->showError( 'config-session-expired',
 198+ $wgLang->formatTimePeriod( $lifetime ) );
195199 }
196200
197201 $this->parent->setSession( 'test', true );
@@ -203,8 +207,10 @@
204208 }
205209 $this->startForm();
206210 $s = Html::hidden( 'LanguageRequestTime', time() ) .
207 - $this->getLanguageSelector( 'UserLang', 'config-your-language', $userLang, $this->parent->getHelpBox( 'config-your-language-help' ) ) .
208 - $this->getLanguageSelector( 'ContLang', 'config-wiki-language', $contLang, $this->parent->getHelpBox( 'config-wiki-language-help' ) );
 211+ $this->getLanguageSelector( 'UserLang', 'config-your-language', $userLang,
 212+ $this->parent->getHelpBox( 'config-your-language-help' ) ) .
 213+ $this->getLanguageSelector( 'ContLang', 'config-wiki-language', $contLang,
 214+ $this->parent->getHelpBox( 'config-wiki-language-help' ) );
209215 $this->addHTML( $s );
210216 $this->endForm( 'continue', false );
211217 }
@@ -223,7 +229,8 @@
224230
225231 $s = $helpHtml;
226232
227 - $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name, 'tabindex' => $this->parent->nextTabIndex() ) ) . "\n";
 233+ $s .= Html::openElement( 'select', array( 'id' => $name, 'name' => $name,
 234+ 'tabindex' => $this->parent->nextTabIndex() ) ) . "\n";
228235
229236 $languages = Language::getLanguageNames();
230237 ksort( $languages );
@@ -340,7 +347,8 @@
341348 */
342349 protected function handleExistingUpgrade( $vars ) {
343350 // Check $wgDBtype
344 - if ( !isset( $vars['wgDBtype'] ) || !in_array( $vars['wgDBtype'], Installer::getDBTypes() ) ) {
 351+ if ( !isset( $vars['wgDBtype'] ) ||
 352+ !in_array( $vars['wgDBtype'], Installer::getDBTypes() ) ) {
345353 return Status::newFatal( 'config-localsettings-connection-error', '' );
346354 }
347355
@@ -451,7 +459,8 @@
452460 "</li>\n";
453461
454462 $settings .=
455 - Html::openElement( 'div', array( 'id' => 'DB_wrapper_' . $type, 'class' => 'dbWrapper' ) ) .
 463+ Html::openElement( 'div', array( 'id' => 'DB_wrapper_' . $type,
 464+ 'class' => 'dbWrapper' ) ) .
456465 Html::element( 'h3', array(), wfMsg( 'config-header-' . $type ) ) .
457466 $installer->getConnectForm() .
458467 "</div>\n";
@@ -624,7 +633,8 @@
625634 'label' => 'config-project-namespace',
626635 'itemLabelPrefix' => 'config-ns-',
627636 'values' => array( 'site-name', 'generic', 'other' ),
628 - 'commonAttribs' => array( 'class' => 'enableForOther', 'rel' => 'config_wgMetaNamespace' ),
 637+ 'commonAttribs' => array( 'class' => 'enableForOther',
 638+ 'rel' => 'config_wgMetaNamespace' ),
629639 'help' => $this->parent->getHelpBox( 'config-project-namespace-help' )
630640 ) ) .
631641 $this->parent->getTextBox( array(
@@ -1180,10 +1190,12 @@
11811191 // Pop up a dialog box, to make it difficult for the user to forget
11821192 // to download the file
11831193 $lsUrl = $this->getVar( 'wgServer' ) . $this->parent->getURL( array( 'localsettings' => 1 ) );
1184 - if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && strpos( $_SERVER['HTTP_USER_AGENT'], 'MSIE' ) !== false ) {
 1194+ if ( isset( $_SERVER['HTTP_USER_AGENT'] ) &&
 1195+ strpos( $_SERVER['HTTP_USER_AGENT'], 'MSIE' ) !== false ) {
11851196 // JS appears the only method that works consistently with IE7+
1186 - $this->addHtml( "\n<script type=\"" . $GLOBALS['wgJsMimeType'] . '">jQuery( document ).ready( function() { document.location='
1187 - . Xml::encodeJsVar( $lsUrl) . "; } );</script>\n" );
 1197+ $this->addHtml( "\n<script type=\"" . $GLOBALS['wgJsMimeType'] .
 1198+ '">jQuery( document ).ready( function() { document.location=' .
 1199+ Xml::encodeJsVar( $lsUrl) . "; } );</script>\n" );
11881200 } else {
11891201 $this->parent->request->response()->header( "Refresh: 0;url=$lsUrl" );
11901202 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102027Apply for Bug #31694 -- "During installation, tabbing order (cursor focus) go...mah18:47, 4 November 2011

Status & tagging log