r98997 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98996‎ | r98997 | r98998 >
Date:13:15, 5 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix bug in r83814 reported on IRC: categorymembers did not set an ORDER BY when cmcontinue was set, which broke paging when cmdir=desc was used.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryCategoryMembers.php
@@ -143,7 +143,9 @@
144144 $contWhere = "cl_sortkey $op $escSortkey OR " .
145145 "(cl_sortkey = $escSortkey AND " .
146146 "cl_from $op= $from)";
147 -
 147+ // The below produces ORDER BY cl_sortkey, cl_from, possibly with DESC added to each of them
 148+ $this->addWhereRange( 'cl_sortkey', $dir, null, null );
 149+ $this->addWhereRange( 'cl_from', $dir, null, null );
148150 } else {
149151 // The below produces ORDER BY cl_sortkey, cl_from, possibly with DESC added to each of them
150152 $this->addWhereRange( 'cl_sortkey',

Follow-up revisions

RevisionCommit summaryAuthorDate
r989981.18wmf1: MFT r98997catrope13:16, 5 October 2011
r100750REL1_18 MFT r98997, r99118, r99370, r99700, r100239, r100242, r100347, r10051...reedy21:51, 25 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83814(bug 27965) Paging in list=categorymembers was completely broken. It was pagi...catrope10:39, 13 March 2011

Status & tagging log