r100760 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100759‎ | r100760 | r100761 >
Date:23:08, 25 October 2011
Author:reedy
Status:ok
Tags:
Comment:
1.18wmf1 MFT r100092, r100419, r100686, r100692
Modified paths:
  • /branches/wmf/1.18wmf1/extensions (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/AbuseFilter/AbuseFilter.hooks.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CodeReview/modules/ext.codereview.js (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/Collection (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/Collection/js/collection.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/AbuseFilter/AbuseFilter.hooks.php
@@ -10,18 +10,19 @@
1111 // Load vars
1212 $vars = new AbuseFilterVariableHolder;
1313
14 - // Cache article object so we can share a parse operation
15 - $title = $editor->mTitle;
16 - $articleCacheKey = $title->getNamespace() . ':' . $title->getText();
17 - AFComputedVariable::$articleCache[$articleCacheKey] = $editor->mArticle;
18 -
1914 // Check for null edits.
2015 $oldtext = '';
2116
2217 if ( $editor->mArticle->exists() ) {
23 - $oldtext = $editor->mArticle->getContent();
 18+ // Make sure we load the latest text saved in database (bug 31656)
 19+ $oldtext = $editor->mArticle->getRevision()->getRawText();
2420 }
2521
 22+ // Cache article object so we can share a parse operation
 23+ $title = $editor->mTitle;
 24+ $articleCacheKey = $title->getNamespace() . ':' . $title->getText();
 25+ AFComputedVariable::$articleCache[$articleCacheKey] = $editor->mArticle;
 26+
2627 if ( strcmp( $oldtext, $text ) == 0 ) {
2728 // Don't trigger for null edits.
2829 return true;
Index: branches/wmf/1.18wmf1/extensions/Collection/js/collection.js
@@ -158,7 +158,7 @@
159159 return;
160160 }
161161 if (!$('#communityCollTitle').length || $('#personalCollType:checked').val()) {
162 - $('#personalCollTitle').attr('disabled', '');
 162+ $('#personalCollTitle').removeAttr('disabled');
163163 $('#communityCollTitle').attr('disabled', 'disabled');
164164 if (!$.trim($('#personalCollTitle').val())) {
165165 $('#saveButton').attr('disabled', 'disabled');
Property changes on: branches/wmf/1.18wmf1/extensions/Collection/js/collection.js
___________________________________________________________________
Modified: svn:mergeinfo
166166 Merged /trunk/extensions/Collection/js/collection.js:r100686,100692
Property changes on: branches/wmf/1.18wmf1/extensions/Collection
___________________________________________________________________
Modified: svn:mergeinfo
167167 Merged /trunk/extensions/Collection:r100686,100692
Index: branches/wmf/1.18wmf1/extensions/CodeReview/modules/ext.codereview.js
@@ -26,7 +26,7 @@
2727 good = false;
2828 }
2929 }
30 - if( good && tags[i].indexOf( lastTag ) != -1 ){
 30+ if( good && ('' + tags[i]).indexOf( lastTag ) != -1 ){
3131 suggestions.push( doneTags + tags[i] );
3232 }
3333 }
Property changes on: branches/wmf/1.18wmf1/extensions/CodeReview
___________________________________________________________________
Modified: svn:mergeinfo
3434 Merged /trunk/extensions/CodeReview:r100092,100419,100686,100692
Property changes on: branches/wmf/1.18wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
3535 Merged /trunk/extensions:r100092,100419,100686,100692

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100092ext.codereview.js: Fix bug 31785...krinkle22:35, 17 October 2011
r100419Fix r100302, r100255: remove duplicate "have", sent -> send, email -> e-mailrobin14:00, 21 October 2011
r100686fixed bug 31821 (Special:Book not allowing saving)ckepper10:00, 25 October 2011
r100692(bug 31656) AbuseFilter skips non null edits...hashar12:46, 25 October 2011

Status & tagging log