r99031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99030‎ | r99031 | r99032 >
Date:19:27, 5 October 2011
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
Fix the bug reported on w:en:WP:VP/T where clicking on links in sortable table headers sorts the table rather than following the link
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
——@@ -663,6 +663,10 @@
664664 };
665665 return false;
666666 }
 667+ } )
 668+ // Allow links in headers to be clicked
 669+ .find( 'a' ).click( function( e ) {
 670+ e.stopPropagation();
667671 } );
668672
669673 } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r990321.18wmf1: MFT r99031catrope19:29, 5 October 2011
r100701(bug 31514) Followup r99031: allow clicking of links in table headers in a di...catrope14:41, 25 October 2011
r101202REL1_18 MFT r98669, r99031, r99321, r99994reedy21:14, 28 October 2011

Comments

#Comment by TheDJ (talk | contribs)   10:48, 8 October 2011

This also kill propagation towards the collapsible element.... Bug 31514

#Comment by Liangent (talk | contribs)   15:10, 8 October 2011

So tag this commit as FIXME?

Status & tagging log