r99097 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99096‎ | r99097 | r99098 >
Date:13:15, 6 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IE
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.config.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.config.js
——@@ -457,7 +457,7 @@
458458 },
459459 'offset': {
460460 'default': [-70, -142],
461 - 'default-rtl': [-70, -502],
 461+ 'default-rtl': [-70, -502]
462462 },
463463 'action': {
464464 'type': 'encapsulate',

Follow-up revisions

RevisionCommit summaryAuthorDate
r990981.18wmf1: MFT r99096, r99097catrope13:17, 6 October 2011
r100383REL1_18 MFT r97886, r97899, r97969, r98179, r98497, r98654, r98773, r98801, r...reedy21:36, 20 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86853Fixes bug 24088: WikiEditor toolbar RTL iconsjanpaul12312:26, 25 April 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   15:31, 6 October 2011

was added to 1.18wmf1, please consider tagging for 1.18 as well.

#Comment by 😂 (talk | contribs)   15:32, 6 October 2011

Let's also tag for 1.4-1.17 :D

#Comment by G.Hagedorn (talk | contribs)   15:53, 6 October 2011

Not really, but as someone who has struggled with an unusable 1.17, I try to convince you to fix both 1.18 and 1.18wmf1 version :-)

Is there a good reason the WikiEditor should continue to fail to work in IE in 1.18, while working in 1.18wmf1?

#Comment by 😂 (talk | contribs)   15:57, 6 October 2011

No, I was being sarcastic :)

#Comment by MarkAHershberger (talk | contribs)   05:31, 9 October 2011

https://secure.wikimedia.org/wikipedia/en/w/index.php?diff=454629090

"I'm still having this problem. I have cleared my cache and restarted the program since the announcement that it was resolved was made, but to no avail"

#Comment by Krinkle (talk | contribs)   20:25, 17 October 2011

Marking OK. Whatever the bug reporter is seeing isn't caused by this revision. This revision is fixing a bug causing there to be less (or no) errors.

Status & tagging log