r99098 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99097‎ | r99098 | r99099 >
Date:13:17, 6 October 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r99096, r99097
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.config.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.config.js
@@ -457,7 +457,7 @@
458458 },
459459 'offset': {
460460 'default': [-70, -142],
461 - 'default-rtl': [-70, -502],
 461+ 'default-rtl': [-70, -502]
462462 },
463463 'action': {
464464 'type': 'encapsulate',
Index: branches/wmf/1.18wmf1/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
@@ -21,6 +21,8 @@
2222 && mw.util.getParamValue( 'redirect' ) != 'no'
2323 // Not viewing the printable version
2424 && mw.util.getParamValue( 'printable' ) != 'yes'
 25+ // Not using CologneBlue skin (see bug 31410)
 26+ && mw.config.get( 'skin' ) != 'cologneblue'
2527 ) {
2628 // Assign a tracking bucket using options from wgArticleFeedbackTracking
2729 mw.user.bucket(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99096Temporarily disable the AFT widget in the cologneblue skin pending resolution...catrope13:05, 6 October 2011
r99097(bug 31411) Remove stray comma introduced in r86853, broke WikiEditor in IEcatrope13:15, 6 October 2011

Status & tagging log