r98718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98717‎ | r98718 | r98719 >
Date:21:07, 2 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r98707: apply this logic to signupend too, per a bug comment.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -221,7 +221,8 @@
222222 * (bug 30497) Add client-nojs and client-js classes on document element
223223 to let styles easily hide or show things based on general JS availability
224224 * (bug 31293) If Special:Userlogin is loaded over HTTPS, display
225 - MediaWiki:loginend-https instead of MediaWiki:loginend, if it's not empty
 225+ MediaWiki:loginend-https instead of MediaWiki:loginend, if it's not empty.
 226+ Same for signupend on the account creation page.
226227
227228 === Bug fixes in 1.18 ===
228229 * mw.util.getScript has been implemented (like wfScript in GlobalFunctions.php)
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -1041,12 +1041,20 @@
10421042 }
10431043
10441044 // Use loginend-https for HTTPS requests if it's not blank, loginend otherwise
1045 - $httpsMsg = wfMessage( 'loginend-https' );
1046 - if ( WebRequest::detectProtocol() == 'https' && !$httpsMsg->isBlank() ) {
1047 - $template->set( 'loginend', $httpsMsg->parse() );
 1045+ // Ditto for signupend
 1046+ $usingHTTPS = WebRequest::detectProtocol();
 1047+ $loginendHTTPS = wfMessage( 'loginend-https' );
 1048+ $signupendHTTPS = wfMessage( 'signupend-https' );
 1049+ if ( $usingHTTPS && !$loginendHTTPS->isBlank() ) {
 1050+ $template->set( 'loginend', $loginendHTTPS->parse() );
10481051 } else {
10491052 $template->set( 'loginend', wfMessage( 'loginend' )->parse() );
10501053 }
 1054+ if ( $usingHTTPS && !$signupendHTTPS->isBlank() ) {
 1055+ $template->set( 'signupend', $signupendHTTPS->parse() );
 1056+ } else {
 1057+ $template->set( 'signupend', wfMessage( 'signupend' )->parse() );
 1058+ }
10511059
10521060 // Give authentication and captcha plugins a chance to modify the form
10531061 $wgAuth->modifyUITemplate( $template, $this->mType );
Index: trunk/phase3/includes/templates/Userlogin.php
@@ -377,7 +377,7 @@
378378 <?php if( $this->haveData( 'token' ) ) { ?><input type="hidden" name="wpCreateaccountToken" value="<?php $this->text( 'token' ); ?>" /><?php } ?>
379379 </form>
380380 </div>
381 -<div id="signupend"><?php $this->msgWiki( 'signupend' ); ?></div>
 381+<div id="signupend"><?php $this->html( 'signupend' ); ?></div>
382382 <?php
383383
384384 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r98719Followup r98718: Register new message key with content per chat with Roan and...raymond21:18, 2 October 2011
r987211.17wmf1: MFT r98713, r98716, r98718, r98719, r98720catrope21:46, 2 October 2011
r987221.18wmf1: MFT r98713, r98716, r98718, r98719, r98720catrope21:47, 2 October 2011
r98762REL1_18 MFT r97806, r97895, r98193, r98194, r98237, r98502, r98656, r98707, r...reedy13:56, 3 October 2011
r98774Fix embarrassing mistake in r98718catrope16:26, 3 October 2011
r99989REL1_18:...reedy22:24, 16 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98707(bug 31293) If Special:Userlogin is loaded over HTTPS, display MediaWiki:logi...catrope20:02, 2 October 2011

Status & tagging log