r98713 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98712‎ | r98713 | r98714 >
Date:20:44, 2 October 2011
Author:raymond
Status:resolved (Comments)
Tags:
Comment:
Followup r98707: Register new message key and set it to ignore for translatewiki.net
This way the key is shown in Special:Allmessages even if empty.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1114,6 +1114,7 @@
11151115 To prevent abuse, only one password reminder will be sent per {{PLURAL:$1|hour|$1 hours}}.',
11161116 'loginstart' => '', # do not translate or duplicate this message to other languages
11171117 'loginend' => '', # do not translate or duplicate this message to other languages
 1118+'loginend-https' => '', # do not translate or duplicate this message to other languages
11181119 'signupstart' => '{{int:loginstart}}', # do not translate or duplicate this message to other languages
11191120 'signupend' => '{{int:loginend}}', # do not translate or duplicate this message to other languages
11201121 'mailerror' => 'Error sending mail: $1',
Index: trunk/phase3/maintenance/language/messages.inc
@@ -469,6 +469,7 @@
470470 'throttled-mailpassword',
471471 'loginstart',
472472 'loginend',
 473+ 'loginend-https',
473474 'signupstart',
474475 'signupend',
475476 'mailerror',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -105,6 +105,7 @@
106106 'history_copyright',
107107 'licenses',
108108 'loginstart',
 109+ 'loginend-https',
109110 'loginend',
110111 'loginlanguagelinks',
111112 'pear-mail-error',

Follow-up revisions

RevisionCommit summaryAuthorDate
r98716Followup r98707, r98713: check for blankness, not nonexistence. Since r98713 ...catrope20:58, 2 October 2011
r987211.17wmf1: MFT r98713, r98716, r98718, r98719, r98720catrope21:46, 2 October 2011
r987221.18wmf1: MFT r98713, r98716, r98718, r98719, r98720catrope21:47, 2 October 2011
r98762REL1_18 MFT r97806, r97895, r98193, r98194, r98237, r98502, r98656, r98707, r...reedy13:56, 3 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98707(bug 31293) If Special:Userlogin is loaded over HTTPS, display MediaWiki:logi...catrope20:02, 2 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   20:57, 2 October 2011

This breaks the ->exists() logic in r98707.

Status & tagging log