r98774 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98773‎ | r98774 | r98775 >
Date:16:26, 3 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Fix embarrassing mistake in r98718
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -1042,7 +1042,7 @@
10431043
10441044 // Use loginend-https for HTTPS requests if it's not blank, loginend otherwise
10451045 // Ditto for signupend
1046 - $usingHTTPS = WebRequest::detectProtocol();
 1046+ $usingHTTPS = WebRequest::detectProtocol() == 'https';
10471047 $loginendHTTPS = wfMessage( 'loginend-https' );
10481048 $signupendHTTPS = wfMessage( 'signupend-https' );
10491049 if ( $usingHTTPS && !$loginendHTTPS->isBlank() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r987751.17wmf1: MFT r98774catrope16:27, 3 October 2011
r987761.18wmf1: MFT r98774catrope16:27, 3 October 2011
r99989REL1_18:...reedy22:24, 16 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98718Followup r98707: apply this logic to signupend too, per a bug comment.catrope21:07, 2 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   19:57, 4 October 2011

Nobody using === anymore?

Status & tagging log