r98237 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98236‎ | r98237 | r98238 >
Date:19:21, 27 September 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 31191) Followup to r90934: do this in the successful login code path too. The bug didn't surface in most cases because the user is redirected immediately after a successful login, except when CentralAuth stops that from happening.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -569,6 +569,10 @@
570570 } else {
571571 $wgAuth->updateUser( $u );
572572 $wgUser = $u;
 573+ // This should set it for OutputPage and the Skin
 574+ // which is needed or the personal links will be
 575+ // wrong.
 576+ RequestContext::getMain()->setUser( $u );
573577
574578 // Please reset throttle for successful logins, thanks!
575579 if ( $throttleCount ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r982381.18wmf1: MFT r98237catrope19:30, 27 September 2011
r98762REL1_18 MFT r97806, r97895, r98193, r98194, r98237, r98502, r98656, r98707, r...reedy13:56, 3 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90934(follow-up to some RequestContext revision) When Special:userlogin creates a ...bawolff04:00, 28 June 2011

Status & tagging log