r98716 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98715‎ | r98716 | r98717 >
Date:20:58, 2 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r98707, r98713: check for blankness, not nonexistence. Since r98713 the -https message always exists, so the check was broken
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -221,7 +221,7 @@
222222 * (bug 30497) Add client-nojs and client-js classes on document element
223223 to let styles easily hide or show things based on general JS availability
224224 * (bug 31293) If Special:Userlogin is loaded over HTTPS, display
225 - MediaWiki:loginend-https instead of MediaWiki:loginend, if it exists
 225+ MediaWiki:loginend-https instead of MediaWiki:loginend, if it's not empty
226226
227227 === Bug fixes in 1.18 ===
228228 * mw.util.getScript has been implemented (like wfScript in GlobalFunctions.php)
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -1040,9 +1040,9 @@
10411041 $template->set( 'uselang', $this->mLanguage );
10421042 }
10431043
1044 - // Use loginend-https for HTTPS requests if it exists, loginend otherwise
 1044+ // Use loginend-https for HTTPS requests if it's not blank, loginend otherwise
10451045 $httpsMsg = wfMessage( 'loginend-https' );
1046 - if ( WebRequest::detectProtocol() == 'https' && $httpsMsg->exists() ) {
 1046+ if ( WebRequest::detectProtocol() == 'https' && !$httpsMsg->isBlank() ) {
10471047 $template->set( 'loginend', $httpsMsg->parse() );
10481048 } else {
10491049 $template->set( 'loginend', wfMessage( 'loginend' )->parse() );

Follow-up revisions

RevisionCommit summaryAuthorDate
r987211.17wmf1: MFT r98713, r98716, r98718, r98719, r98720catrope21:46, 2 October 2011
r987221.18wmf1: MFT r98713, r98716, r98718, r98719, r98720catrope21:47, 2 October 2011
r98762REL1_18 MFT r97806, r97895, r98193, r98194, r98237, r98502, r98656, r98707, r...reedy13:56, 3 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98707(bug 31293) If Special:Userlogin is loaded over HTTPS, display MediaWiki:logi...catrope20:02, 2 October 2011
r98713Followup r98707: Register new message key and set it to ignore for translatew...raymond20:44, 2 October 2011

Status & tagging log