r97634 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97633‎ | r97634 | r97635 >
Date:15:33, 20 September 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Followup r97623: some fixes for RTL in IE70Fixes.css:
* Remove useless .rtl #bodyContent a.external rule, already handled by CSSJanus
* Flip the div#column-content div#content hack in RTL mode so the content area doesn't end prematurely on the left
* Fix display of the user icon next to the login link or user name
* External link icons are still broken in IE7+RTL, but they were already broken in 1.17 and are also broken in Vector
Modified paths:
  • /trunk/phase3/skins/monobook/IE70Fixes.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE70Fixes.css
——@@ -9,6 +9,9 @@
1010 height: 1%;
1111 }
1212
 13+.rtl div#column-content div#content { margin-right: 12.2em; margin-left: 0; }
 14+
 15+
1316 .rtl div#column-one {
1417 /* For some reason it tries to inherit the padding-top into every div,
1518 * and I can't figure out how to get it back off.
——@@ -18,9 +21,13 @@
1922 margin-top: 160px;
2023 }
2124
22 -.rtl #bodyContent a.external {
23 - background-image: url(external-rtl.png);
24 - padding: 0 13px 0 0;
 25+/* These elements also have padding-left: 20px; in main.css, but in RTL mode this is flipped.
 26+ * That's good in normal browsers, but in IE7 it needs to not be flipped for some daft reason.
 27+ * Also clear the right margin (originally margin-left: 1em)
 28+ */
 29+li#pt-userpage, li#pt-anonuserpage, li#pt-login {
 30+ padding-left: 20px;
 31+ margin-right: 0;
2532 }
2633
2734 .rtl a.feedlink {

Follow-up revisions

RevisionCommit summaryAuthorDate
r976381.18wmf1: MFT r97623, r97634catrope15:59, 20 September 2011
r97652Break line in r97634catrope19:18, 20 September 2011
r97673REL1_18 MFT r96760, r76765, r96810, r97551, r97552, r97575, r97607, r97608, r...reedy22:36, 20 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97623Reinstate IE*Fixes.css . This fixes most of the breakage from r74966, but the...catrope13:21, 20 September 2011

Comments

#Comment by Krinkle (talk | contribs)   00:28, 21 September 2011

* External link icons are still broken in IE7+RTL, but they were already broken in 1.17 and are also broken in Vector

Why exactly are they broken ? In theory the padding direction is flipped and the referenced icon file name is also swapped from ltr/rtl. What fails in IE6/7 specifically ?

#Comment by Catrope (talk | contribs)   01:39, 21 September 2011

Yes, in theory it's nicely flipped. In practice it doesn't work that way, and you get something like this.

Status & tagging log