r97607 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97606‎ | r97607 | r97608 >
Date:09:13, 20 September 2011
Author:catrope
Status:ok
Tags:todo 
Comment:
Accept ResourceLoader URLs containing '!' in '.' for backwards compatibility with a hack that existed in MediaWiki at some point (was in trunk and 1.17wmf1 but never in any release). This is needed because Squid-cached HTML at Wikimedia still contains such URLs.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderContext.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderContext.php
@@ -73,6 +73,8 @@
7474 */
7575 public static function expandModuleNames( $modules ) {
7676 $retval = array();
 77+ // For backwards compatibility with an earlier hack, replace ! with .
 78+ $modules = str_replace( '!', '.', $modules );
7779 $exploded = explode( '|', $modules );
7880 foreach ( $exploded as $group ) {
7981 if ( strpos( $group, ',' ) === false ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r976101.18wmf1: MFT r97607, r97608 (ResourceLoader fixes)catrope09:20, 20 September 2011
r97673REL1_18 MFT r96760, r76765, r96810, r97551, r97552, r97575, r97607, r97608, r...reedy22:36, 20 September 2011

Status & tagging log