r97623 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97622‎ | r97623 | r97624 >
Date:13:21, 20 September 2011
Author:catrope
Status:ok
Tags:
Comment:
Reinstate IE*Fixes.css . This fixes most of the breakage from r74966, but there's one thing (icon placement) that's still broken in IE7 in RTL. Seems like it shouldn't be hard to fix though, I'll poke Trevor
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
——@@ -39,10 +39,10 @@
4040 }
4141
4242 // TODO: Migrate all of these
43 - //$out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
44 - //$out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
45 - //$out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
46 - //$out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
 43+ $out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
 44+ $out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
 45+ $out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
 46+ $out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
4747
4848 }
4949 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r97634Followup r97623: some fixes for RTL in IE70Fixes.css:...catrope15:33, 20 September 2011
r976381.18wmf1: MFT r97623, r97634catrope15:59, 20 September 2011
r97673REL1_18 MFT r96760, r76765, r96810, r97551, r97552, r97575, r97607, r97608, r...reedy22:36, 20 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74966First shot at porting Monobook to Vector. The only non-straightforward part i...catrope20:35, 18 October 2010

Status & tagging log