r97638 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97637‎ | r97638 | r97639 >
Date:15:59, 20 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r97623, r97634
Modified paths:
  • /branches/wmf/1.18wmf1/skins/MonoBook.php (modified) (history)
  • /branches/wmf/1.18wmf1/skins/monobook/IE70Fixes.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/skins/monobook/IE70Fixes.css
@@ -9,6 +9,9 @@
1010 height: 1%;
1111 }
1212
 13+.rtl div#column-content div#content { margin-right: 12.2em; margin-left: 0; }
 14+
 15+
1316 .rtl div#column-one {
1417 /* For some reason it tries to inherit the padding-top into every div,
1518 * and I can't figure out how to get it back off.
@@ -18,9 +21,13 @@
1922 margin-top: 160px;
2023 }
2124
22 -.rtl #bodyContent a.external {
23 - background-image: url(external-rtl.png);
24 - padding: 0 13px 0 0;
 25+/* These elements also have padding-left: 20px; in main.css, but in RTL mode this is flipped.
 26+ * That's good in normal browsers, but in IE7 it needs to not be flipped for some daft reason.
 27+ * Also clear the right margin (originally margin-left: 1em)
 28+ */
 29+li#pt-userpage, li#pt-anonuserpage, li#pt-login {
 30+ padding-left: 20px;
 31+ margin-right: 0;
2532 }
2633
2734 .rtl a.feedlink {
Index: branches/wmf/1.18wmf1/skins/MonoBook.php
@@ -36,10 +36,10 @@
3737 }
3838
3939 // TODO: Migrate all of these
40 - //$out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
41 - //$out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
42 - //$out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
43 - //$out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
 40+ $out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
 41+ $out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
 42+ $out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
 43+ $out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
4444
4545 }
4646 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97623Reinstate IE*Fixes.css . This fixes most of the breakage from r74966, but the...catrope13:21, 20 September 2011
r97634Followup r97623: some fixes for RTL in IE70Fixes.css:...catrope15:33, 20 September 2011

Status & tagging log