r97608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97607‎ | r97608 | r97609 >
Date:09:16, 20 September 2011
Author:catrope
Status:ok
Tags:
Comment:
For backwards compatibility with cached HTML generated by MediaWiki 1.17, re-introduce mw.loader.go() . This would have normally been a no-op, but because there is another inconsistency between 1.17 and 1.18 (loading of mw.user) I decided it to abuse it to cover that too. Thanks for Derk-Jan Hartman for reporting the JS errors on test2wiki and figuring out that they were caused by incompatibilities in Squid-cached HTML.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
——@@ -1175,6 +1175,11 @@
11761176 } );
11771177 return names;
11781178 };
 1179+
 1180+ /**
 1181+ * For backwards-compatibility with Squid-cached pages. Loads mw.user
 1182+ */
 1183+ this.go = function() { mw.loader.load( 'mediawiki.user' ); };
11791184
11801185 /* Cache document ready status */
11811186

Follow-up revisions

RevisionCommit summaryAuthorDate
r976101.18wmf1: MFT r97607, r97608 (ResourceLoader fixes)catrope09:20, 20 September 2011
r97673REL1_18 MFT r96760, r76765, r96810, r97551, r97552, r97575, r97607, r97608, r...reedy22:36, 20 September 2011

Status & tagging log