r90723 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90722‎ | r90723 | r90724 >
Date:18:12, 24 June 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 29564) Fix XML export output when LiquidThreads thread data contains bogus UTF-8

We should still fix the input validation so that signature threads are truncated cleanly etc, but this will fix the XML export of such bogus data by running the bits through UtfNormal::cleanUp(). This applies UTF-8 validation, removes bogus sequences, and also applies NFC transformations, as is already done on the rest of the XML export output.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/Hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/Hooks.php
——@@ -199,7 +199,7 @@
200200 $threadInfo .= "\t" . Xml::element( $key, null, $value ) . "\n";
201201 }
202202
203 - $out .= Xml::tags( 'DiscussionThreading', null, $threadInfo ) . "\n";
 203+ $out .= UtfNormal::cleanUp( Xml::tags( 'DiscussionThreading', null, $threadInfo ) . "\n" );
204204
205205 return true;
206206 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r91986MFT r90723demon19:09, 12 July 2011
r92258MFT r90221, r90723, r91145reedy17:49, 15 July 2011
r92324REL_1.18 MFT r89121, r89266, r90723, r90857, r91578, r92300reedy22:08, 15 July 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:14, 24 June 2011

Needs merge to 1.17 and 1.18 release branches and the current deployment branch; should fix XML export dumps for huwiki and any other affected wikis.

Status & tagging log