r92324 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92323‎ | r92324 | r92325 >
Date:22:08, 15 July 2011
Author:reedy
Status:deferred
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/CentralAuth/specials/SpecialCentralAuth.php (modified) (history)
  • /branches/REL1_18/extensions/Cite/citeParserTests.txt (modified) (history)
  • /branches/REL1_18/extensions/GlobalBlocking/GlobalBlocking.class.php (modified) (history)
  • /branches/REL1_18/extensions/LiquidThreads (modified) (history)
  • /branches/REL1_18/extensions/LiquidThreads/LiquidThreads.php (modified) (history)
  • /branches/REL1_18/extensions/LiquidThreads/classes/Hooks.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/LiquidThreads/LiquidThreads.php
@@ -71,7 +71,7 @@
7272 $wgResourceModules['ext.liquidThreads'] = $lqtResourceTemplate + array(
7373 'styles' => array( 'lqt.css', 'jquery/jquery.thread_collapse.css', 'lqt.dialogs.css' ),
7474 'scripts' => array( 'lqt.js', 'js/lqt.toolbar.js', 'jquery/jquery.thread_collapse.js', 'jquery/jquery.autogrow.js' ),
75 - 'dependencies' => array( 'jquery.ui.dialog' ),
 75+ 'dependencies' => array( 'jquery.ui.dialog', 'jquery.ui.droppable' ),
7676 'messages' => $lqtMessages
7777 );
7878
Index: branches/REL1_18/extensions/LiquidThreads/classes/Hooks.php
@@ -199,7 +199,7 @@
200200 $threadInfo .= "\t" . Xml::element( $key, null, $value ) . "\n";
201201 }
202202
203 - $out .= Xml::tags( 'DiscussionThreading', null, $threadInfo ) . "\n";
 203+ $out .= UtfNormal::cleanUp( Xml::tags( 'DiscussionThreading', null, $threadInfo ) . "\n" );
204204
205205 return true;
206206 }
Property changes on: branches/REL1_18/extensions/LiquidThreads
___________________________________________________________________
Modified: svn:mergeinfo
207207 Merged /trunk/extensions/LiquidThreads:r89121,89266,90723,90857,91578,92300
Index: branches/REL1_18/extensions/GlobalBlocking/GlobalBlocking.class.php
@@ -44,7 +44,7 @@
4545 return $result = array();
4646 }
4747
48 - if ( $user->isAllowed( 'ipblock-exempt', 'globalblock-exempt' ) ) {
 48+ if ( $user->isAllowed( 'ipblock-exempt' ) || $user->isAllowed( 'globalblock-exempt' ) ) {
4949 // User is exempt from IP blocks.
5050 return $result = array();
5151 }
Index: branches/REL1_18/extensions/CentralAuth/specials/SpecialCentralAuth.php
@@ -363,6 +363,12 @@
364364
365365 function listMergedWikiItem( $row ) {
366366 global $wgLang;
 367+ if ( $row === null ) {
 368+ // https://bugzilla.wikimedia.org/show_bug.cgi?id=28767
 369+ // It seems sometimes local accounts aren't correctly created
 370+ // Revisiting the wiki solves the issue
 371+ return '';
 372+ }
367373 return '<tr>' .
368374 ( $this->mCanUnmerge ? '<td>' . $this->adminCheck( $row['wiki'] ) . '</td>' : '' ) .
369375 '<td>' . $this->foreignUserLink( $row['wiki'] ) . '</td>' .
Index: branches/REL1_18/extensions/Cite/citeParserTests.txt
@@ -112,7 +112,7 @@
113113 </p>
114114 <ul class="gallery">
115115 <li class="gallerybox" style="width: 155px"><div style="width: 155px">
116 - <div class="thumb" style="width: 150px;"><div style="margin:66px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
 116+ <div class="thumb" style="width: 150px;"><div style="margin:68px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="http://example.com/images/3/3a/Foobar.jpg" width="120" height="14" /></a></div></div>
117117 <div class="gallerytext">
118118 </div>
119119 </div></li>
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Added: svn:mergeinfo
120120 Merged /trunk/extensions:r89121,89266,90723,90857,91578,92300

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89121fix for bug28407 - drag to new location not workingwikinaut17:53, 29 May 2011
r89266* (bug 28767) Internal error on Special:CentralAuth/usernamereedy15:34, 1 June 2011
r90723* (bug 29564) Fix XML export output when LiquidThreads thread data contains b...brion18:12, 24 June 2011
r90857Follow-up r84251 - isAllowed( 'right', 'or-another-right' ) was reverted.happy-melon22:05, 26 June 2011
r91578fixing parser test per r91573kaldari18:26, 6 July 2011
r92300Revert r84874: breaks ProofreadPage's UI completely by incorrectly comparing ...brion20:30, 15 July 2011

Status & tagging log